Commit d32c3e26 authored by Dan Carpenter's avatar Dan Carpenter Committed by Linus Walleij

pinctrl: rockchip: missing unlock on error in rockchip_set_pull()

We need to unlock here before returning -EINVAL.

Fixes: 6ca5274d ('pinctrl: rockchip: add rk3188 specifics')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarHeiko Stuebner <heiko@sntech.de>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent c590854d
...@@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank, ...@@ -504,6 +504,7 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank,
data |= (3 << bit); data |= (3 << bit);
break; break;
default: default:
spin_unlock_irqrestore(&bank->slock, flags);
dev_err(info->dev, "unsupported pull setting %d\n", dev_err(info->dev, "unsupported pull setting %d\n",
pull); pull);
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment