Commit d359b549 authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds

[PATCH] futex_find_get_task(): don't take tasklist_lock

It is ok to do find_task_by_pid() + get_task_struct() under
rcu_read_lock(), we cand drop tasklist_lock.

Note that testing of ->exit_state is racy with or without tasklist anyway.
Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Acked-by: default avatarIngo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 44938af6
...@@ -389,7 +389,7 @@ static struct task_struct * futex_find_get_task(pid_t pid) ...@@ -389,7 +389,7 @@ static struct task_struct * futex_find_get_task(pid_t pid)
{ {
struct task_struct *p; struct task_struct *p;
read_lock(&tasklist_lock); rcu_read_lock();
p = find_task_by_pid(pid); p = find_task_by_pid(pid);
if (!p) if (!p)
goto out_unlock; goto out_unlock;
...@@ -403,7 +403,7 @@ static struct task_struct * futex_find_get_task(pid_t pid) ...@@ -403,7 +403,7 @@ static struct task_struct * futex_find_get_task(pid_t pid)
} }
get_task_struct(p); get_task_struct(p);
out_unlock: out_unlock:
read_unlock(&tasklist_lock); rcu_read_unlock();
return p; return p;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment