Commit d3f0c7fa authored by Thorsten Winkler's avatar Thorsten Winkler Committed by Paolo Abeni

s390/lcs: Convert sysfs sprintf to sysfs_emit

Following the advice of the Documentation/filesystems/sysfs.rst.
All sysfs related show()-functions should only use sysfs_emit() or
sysfs_emit_at() when formatting the value to be returned to user space.

While at it, follow Linux kernel coding style and unify indentation
Reported-by: default avatarJules Irenge <jbi.octave@gmail.com>
Reported-by: default avatarJoe Perches <joe@perches.com>
Reviewed-by: default avatarAlexandra Winter <wintera@linux.ibm.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Signed-off-by: default avatarThorsten Winkler <twinkler@linux.ibm.com>
Signed-off-by: default avatarAlexandra Winter <wintera@linux.ibm.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent ebe14dad
...@@ -1899,14 +1899,14 @@ lcs_open_device(struct net_device *dev) ...@@ -1899,14 +1899,14 @@ lcs_open_device(struct net_device *dev)
static ssize_t static ssize_t
lcs_portno_show (struct device *dev, struct device_attribute *attr, char *buf) lcs_portno_show (struct device *dev, struct device_attribute *attr, char *buf)
{ {
struct lcs_card *card; struct lcs_card *card;
card = dev_get_drvdata(dev); card = dev_get_drvdata(dev);
if (!card) if (!card)
return 0; return 0;
return sprintf(buf, "%d\n", card->portno); return sysfs_emit(buf, "%d\n", card->portno);
} }
/* /*
...@@ -1956,7 +1956,8 @@ lcs_type_show(struct device *dev, struct device_attribute *attr, char *buf) ...@@ -1956,7 +1956,8 @@ lcs_type_show(struct device *dev, struct device_attribute *attr, char *buf)
if (!cgdev) if (!cgdev)
return -ENODEV; return -ENODEV;
return sprintf(buf, "%s\n", lcs_type[cgdev->cdev[0]->id.driver_info]); return sysfs_emit(buf, "%s\n",
lcs_type[cgdev->cdev[0]->id.driver_info]);
} }
static DEVICE_ATTR(type, 0444, lcs_type_show, NULL); static DEVICE_ATTR(type, 0444, lcs_type_show, NULL);
...@@ -1968,7 +1969,7 @@ lcs_timeout_show(struct device *dev, struct device_attribute *attr, char *buf) ...@@ -1968,7 +1969,7 @@ lcs_timeout_show(struct device *dev, struct device_attribute *attr, char *buf)
card = dev_get_drvdata(dev); card = dev_get_drvdata(dev);
return card ? sprintf(buf, "%u\n", card->lancmd_timeout) : 0; return card ? sysfs_emit(buf, "%u\n", card->lancmd_timeout) : 0;
} }
static ssize_t static ssize_t
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment