Commit d4a36e82 authored by Yoshihiro Shimoda's avatar Yoshihiro Shimoda Committed by Kishon Vijay Abraham I

phy: renesas: rcar-gen2: Fix memory leak at error paths

This patch fixes memory leak at error paths of the probe function.
In for_each_child_of_node, if the loop returns, the driver should
call of_put_node() before returns.
Reported-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Fixes: 1233f59f ("phy: Renesas R-Car Gen2 PHY driver")
Signed-off-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent d9801081
...@@ -391,6 +391,7 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev) ...@@ -391,6 +391,7 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev)
error = of_property_read_u32(np, "reg", &channel_num); error = of_property_read_u32(np, "reg", &channel_num);
if (error || channel_num > 2) { if (error || channel_num > 2) {
dev_err(dev, "Invalid \"reg\" property\n"); dev_err(dev, "Invalid \"reg\" property\n");
of_node_put(np);
return error; return error;
} }
channel->select_mask = select_mask[channel_num]; channel->select_mask = select_mask[channel_num];
...@@ -406,6 +407,7 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev) ...@@ -406,6 +407,7 @@ static int rcar_gen2_phy_probe(struct platform_device *pdev)
data->gen2_phy_ops); data->gen2_phy_ops);
if (IS_ERR(phy->phy)) { if (IS_ERR(phy->phy)) {
dev_err(dev, "Failed to create PHY\n"); dev_err(dev, "Failed to create PHY\n");
of_node_put(np);
return PTR_ERR(phy->phy); return PTR_ERR(phy->phy);
} }
phy_set_drvdata(phy->phy, phy); phy_set_drvdata(phy->phy, phy);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment