Commit d4c5cef7 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Will Deacon

perf: thunderx2: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/7be677dfa13d3a7eab6eef0d808ba8a9855d14ae.1702648125.git.u.kleine-koenig@pengutronix.deSigned-off-by: default avatarWill Deacon <will@kernel.org>
parent 8a2e438e
...@@ -993,7 +993,7 @@ static int tx2_uncore_probe(struct platform_device *pdev) ...@@ -993,7 +993,7 @@ static int tx2_uncore_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int tx2_uncore_remove(struct platform_device *pdev) static void tx2_uncore_remove(struct platform_device *pdev)
{ {
struct tx2_uncore_pmu *tx2_pmu, *temp; struct tx2_uncore_pmu *tx2_pmu, *temp;
struct device *dev = &pdev->dev; struct device *dev = &pdev->dev;
...@@ -1009,7 +1009,6 @@ static int tx2_uncore_remove(struct platform_device *pdev) ...@@ -1009,7 +1009,6 @@ static int tx2_uncore_remove(struct platform_device *pdev)
} }
} }
} }
return 0;
} }
static struct platform_driver tx2_uncore_driver = { static struct platform_driver tx2_uncore_driver = {
...@@ -1019,7 +1018,7 @@ static struct platform_driver tx2_uncore_driver = { ...@@ -1019,7 +1018,7 @@ static struct platform_driver tx2_uncore_driver = {
.suppress_bind_attrs = true, .suppress_bind_attrs = true,
}, },
.probe = tx2_uncore_probe, .probe = tx2_uncore_probe,
.remove = tx2_uncore_remove, .remove_new = tx2_uncore_remove,
}; };
static int __init tx2_uncore_driver_init(void) static int __init tx2_uncore_driver_init(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment