Commit d5c1118f authored by Cai Huoqing's avatar Cai Huoqing Committed by Jonathan Cameron

iio: dac: max5821: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928013902.1341-5-caihuoqing@baidu.comSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 2b87c267
...@@ -321,12 +321,9 @@ static int max5821_probe(struct i2c_client *client, ...@@ -321,12 +321,9 @@ static int max5821_probe(struct i2c_client *client,
} }
data->vref_reg = devm_regulator_get(&client->dev, "vref"); data->vref_reg = devm_regulator_get(&client->dev, "vref");
if (IS_ERR(data->vref_reg)) { if (IS_ERR(data->vref_reg))
ret = PTR_ERR(data->vref_reg); return dev_err_probe(&client->dev, PTR_ERR(data->vref_reg),
dev_err(&client->dev, "Failed to get vref regulator\n");
"Failed to get vref regulator: %d\n", ret);
return ret;
}
ret = regulator_enable(data->vref_reg); ret = regulator_enable(data->vref_reg);
if (ret) { if (ret) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment