Commit d61e4ba3 authored by Derek Lai's avatar Derek Lai Committed by Alex Deucher

drm/amd/display: do not change pipe split policy for RV2

[Why]
RV2 do not change pipe split policy in the
minimal pipe split transition state.
This will unblock mode support on some
parts that limit to DPM0 for power reason.

[How]
Do not change pipe split policy in the
minimal pipe split transition state to
allow 4k multi display configs to be
supported at DPM0.
Reviewed-by: default avatarCharlene Liu <Charlene.Liu@amd.com>
Acked-by: default avatarBrian Chang <Brian.Chang@amd.com>
Signed-off-by: default avatarDerek Lai <Derek.Lai@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 7930f58a
...@@ -3546,8 +3546,10 @@ static bool commit_minimal_transition_state(struct dc *dc, ...@@ -3546,8 +3546,10 @@ static bool commit_minimal_transition_state(struct dc *dc,
if (!transition_context) if (!transition_context)
return false; return false;
tmp_policy = dc->debug.pipe_split_policy; if (!dc->config.is_vmin_only_asic) {
dc->debug.pipe_split_policy = MPC_SPLIT_AVOID; tmp_policy = dc->debug.pipe_split_policy;
dc->debug.pipe_split_policy = MPC_SPLIT_AVOID;
}
dc_resource_state_copy_construct(transition_base_context, transition_context); dc_resource_state_copy_construct(transition_base_context, transition_context);
...@@ -3573,7 +3575,8 @@ static bool commit_minimal_transition_state(struct dc *dc, ...@@ -3573,7 +3575,8 @@ static bool commit_minimal_transition_state(struct dc *dc,
dc_release_state(transition_context); dc_release_state(transition_context);
//restore previous pipe split policy //restore previous pipe split policy
dc->debug.pipe_split_policy = tmp_policy; if (!dc->config.is_vmin_only_asic)
dc->debug.pipe_split_policy = tmp_policy;
if (ret != DC_OK) { if (ret != DC_OK) {
//this should never happen //this should never happen
......
...@@ -401,6 +401,7 @@ struct dc_config { ...@@ -401,6 +401,7 @@ struct dc_config {
uint8_t vblank_alignment_max_frame_time_diff; uint8_t vblank_alignment_max_frame_time_diff;
bool is_asymmetric_memory; bool is_asymmetric_memory;
bool is_single_rank_dimm; bool is_single_rank_dimm;
bool is_vmin_only_asic;
bool use_pipe_ctx_sync_logic; bool use_pipe_ctx_sync_logic;
bool ignore_dpref_ss; bool ignore_dpref_ss;
bool enable_mipi_converter_optimization; bool enable_mipi_converter_optimization;
......
...@@ -1495,6 +1495,24 @@ static bool dcn10_resource_construct( ...@@ -1495,6 +1495,24 @@ static bool dcn10_resource_construct(
/* Other architectures we build for build this with soft-float */ /* Other architectures we build for build this with soft-float */
dcn10_resource_construct_fp(dc); dcn10_resource_construct_fp(dc);
if (!dc->config.is_vmin_only_asic)
if (ASICREV_IS_RAVEN2(dc->ctx->asic_id.hw_internal_rev))
switch (dc->ctx->asic_id.pci_revision_id) {
case PRID_DALI_DE:
case PRID_DALI_DF:
case PRID_DALI_E3:
case PRID_DALI_E4:
case PRID_POLLOCK_94:
case PRID_POLLOCK_95:
case PRID_POLLOCK_E9:
case PRID_POLLOCK_EA:
case PRID_POLLOCK_EB:
dc->config.is_vmin_only_asic = true;
break;
default:
break;
}
pool->base.pp_smu = dcn10_pp_smu_create(ctx); pool->base.pp_smu = dcn10_pp_smu_create(ctx);
/* /*
......
...@@ -736,30 +736,13 @@ static void hack_bounding_box(struct dcn_bw_internal_vars *v, ...@@ -736,30 +736,13 @@ static void hack_bounding_box(struct dcn_bw_internal_vars *v,
hack_force_pipe_split(v, context->streams[0]->timing.pix_clk_100hz); hack_force_pipe_split(v, context->streams[0]->timing.pix_clk_100hz);
} }
static unsigned int get_highest_allowed_voltage_level(uint32_t chip_family, static unsigned int get_highest_allowed_voltage_level(bool is_vmin_only_asic)
uint32_t hw_internal_rev,
uint32_t pci_revision_id)
{ {
/* for low power RV2 variants, the highest voltage level we want is 0 */ /* for low power RV2 variants, the highest voltage level we want is 0 */
if ((chip_family == FAMILY_RV) && if (is_vmin_only_asic)
ASICREV_IS_RAVEN2(hw_internal_rev)) return 0;
switch (pci_revision_id) { else /* we are ok with all levels */
case PRID_DALI_DE: return 4;
case PRID_DALI_DF:
case PRID_DALI_E3:
case PRID_DALI_E4:
case PRID_POLLOCK_94:
case PRID_POLLOCK_95:
case PRID_POLLOCK_E9:
case PRID_POLLOCK_EA:
case PRID_POLLOCK_EB:
return 0;
default:
break;
}
/* we are ok with all levels */
return 4;
} }
bool dcn_validate_bandwidth( bool dcn_validate_bandwidth(
...@@ -1323,10 +1306,7 @@ bool dcn_validate_bandwidth( ...@@ -1323,10 +1306,7 @@ bool dcn_validate_bandwidth(
PERFORMANCE_TRACE_END(); PERFORMANCE_TRACE_END();
BW_VAL_TRACE_FINISH(); BW_VAL_TRACE_FINISH();
if (bw_limit_pass && v->voltage_level <= get_highest_allowed_voltage_level( if (bw_limit_pass && v->voltage_level <= get_highest_allowed_voltage_level(dc->config.is_vmin_only_asic))
dc->ctx->asic_id.chip_family,
dc->ctx->asic_id.hw_internal_rev,
dc->ctx->asic_id.pci_revision_id))
return true; return true;
else else
return false; return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment