Commit d645148c authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Vinod Koul

dmaengine: milbeaut-xdmac: Fix a resource leak in the error handling path of the probe function

'disable_xdmac()' should be called in the error handling path of the
probe function to undo a previous 'enable_xdmac()' call, as already
done in the remove function.

Fixes: a6e9be05 ("dmaengine: milbeaut-xdmac: Add XDMAC driver for Milbeaut platforms")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/20201219132800.183254-1-christophe.jaillet@wanadoo.frSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 33cbd54d
...@@ -350,7 +350,7 @@ static int milbeaut_xdmac_probe(struct platform_device *pdev) ...@@ -350,7 +350,7 @@ static int milbeaut_xdmac_probe(struct platform_device *pdev)
ret = dma_async_device_register(ddev); ret = dma_async_device_register(ddev);
if (ret) if (ret)
return ret; goto disable_xdmac;
ret = of_dma_controller_register(dev->of_node, ret = of_dma_controller_register(dev->of_node,
of_dma_simple_xlate, mdev); of_dma_simple_xlate, mdev);
...@@ -363,6 +363,8 @@ static int milbeaut_xdmac_probe(struct platform_device *pdev) ...@@ -363,6 +363,8 @@ static int milbeaut_xdmac_probe(struct platform_device *pdev)
unregister_dmac: unregister_dmac:
dma_async_device_unregister(ddev); dma_async_device_unregister(ddev);
disable_xdmac:
disable_xdmac(mdev);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment