Commit d687bdef authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

staging: kpc2000: Fix a stack information leak in kp2000_cdev_ioctl()

The kp2000_regs struct has a 4 byte hole between ->hw_rev and ->ssid so
this could leak stack information to the user.  This patch just memsets
the whole struct to zero.

Fixes: 7dc7967f ("staging: kpc2000: add initial set of Daktronics drivers")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 87232b82
...@@ -91,6 +91,8 @@ long kp2000_cdev_ioctl(struct file *filp, unsigned int ioctl_num, unsigned long ...@@ -91,6 +91,8 @@ long kp2000_cdev_ioctl(struct file *filp, unsigned int ioctl_num, unsigned long
case KP2000_IOCTL_GET_EVERYTHING: { case KP2000_IOCTL_GET_EVERYTHING: {
struct kp2000_regs temp; struct kp2000_regs temp;
int ret; int ret;
memset(&temp, 0, sizeof(temp));
temp.card_id = pcard->card_id; temp.card_id = pcard->card_id;
temp.build_version = pcard->build_version; temp.build_version = pcard->build_version;
temp.build_datestamp = pcard->build_datestamp; temp.build_datestamp = pcard->build_datestamp;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment