Commit d69f763f authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Mark Brown

regulator: da9062: Replace zero-length array with flexible-array member

The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732 ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarAdam Thomson <Adam.Thomson.Opensource@diasemi.com>
Link: https://lore.kernel.org/r/20200211234612.GA28682@embeddedorSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 23a653eb
...@@ -73,7 +73,7 @@ struct da9062_regulators { ...@@ -73,7 +73,7 @@ struct da9062_regulators {
int irq_ldo_lim; int irq_ldo_lim;
unsigned n_regulators; unsigned n_regulators;
/* Array size to be defined during init. Keep at end. */ /* Array size to be defined during init. Keep at end. */
struct da9062_regulator regulator[0]; struct da9062_regulator regulator[];
}; };
/* Regulator operations */ /* Regulator operations */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment