Commit d72f4e29 authored by Ingo Molnar's avatar Ingo Molnar

x86/speculation: Move firmware_restrict_branch_speculation_*() from C to CPP

firmware_restrict_branch_speculation_*() recently started using
preempt_enable()/disable(), but those are relatively high level
primitives and cause build failures on some 32-bit builds.

Since we want to keep <asm/nospec-branch.h> low level, convert
them to macros to avoid header hell...

Cc: David Woodhouse <dwmw@amazon.co.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: arjan.van.de.ven@intel.com
Cc: bp@alien8.de
Cc: dave.hansen@intel.com
Cc: jmattson@google.com
Cc: karahmed@amazon.de
Cc: kvm@vger.kernel.org
Cc: pbonzini@redhat.com
Cc: rkrcmar@redhat.com
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent ca41b97e
...@@ -257,20 +257,22 @@ static inline void indirect_branch_prediction_barrier(void) ...@@ -257,20 +257,22 @@ static inline void indirect_branch_prediction_barrier(void)
/* /*
* With retpoline, we must use IBRS to restrict branch prediction * With retpoline, we must use IBRS to restrict branch prediction
* before calling into firmware. * before calling into firmware.
*
* (Implemented as CPP macros due to header hell.)
*/ */
static inline void firmware_restrict_branch_speculation_start(void) #define firmware_restrict_branch_speculation_start() \
{ do { \
preempt_disable(); preempt_disable(); \
alternative_msr_write(MSR_IA32_SPEC_CTRL, SPEC_CTRL_IBRS, alternative_msr_write(MSR_IA32_SPEC_CTRL, SPEC_CTRL_IBRS, \
X86_FEATURE_USE_IBRS_FW); X86_FEATURE_USE_IBRS_FW); \
} } while (0)
static inline void firmware_restrict_branch_speculation_end(void) #define firmware_restrict_branch_speculation_end() \
{ do { \
alternative_msr_write(MSR_IA32_SPEC_CTRL, 0, alternative_msr_write(MSR_IA32_SPEC_CTRL, 0, \
X86_FEATURE_USE_IBRS_FW); X86_FEATURE_USE_IBRS_FW); \
preempt_enable(); preempt_enable(); \
} } while (0)
#endif /* __ASSEMBLY__ */ #endif /* __ASSEMBLY__ */
#endif /* _ASM_X86_NOSPEC_BRANCH_H_ */ #endif /* _ASM_X86_NOSPEC_BRANCH_H_ */
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment