Commit d73228a7 authored by Laurent Pinchart's avatar Laurent Pinchart Committed by Mauro Carvalho Chehab

media: imx: imx7_mipi_csis: Fully initialize MIPI_CSIS_DPHYCTRL register

When setting the CSIS parameters, write the MIPI_CSIS_DPHYCTRL register
fully instead of modifying selected fields, as the register doesn't
contain any reserved fields that need to be preserved. This simplifies
initialization slightly, and ensures that the register value doesn't
depend on its previous state (before a warm reboot for instance).
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 6eac0eec
...@@ -536,10 +536,8 @@ static void mipi_csis_set_params(struct csi_state *state) ...@@ -536,10 +536,8 @@ static void mipi_csis_set_params(struct csi_state *state)
__mipi_csis_set_format(state); __mipi_csis_set_format(state);
val = mipi_csis_read(state, MIPI_CSIS_DPHYCTRL); mipi_csis_write(state, MIPI_CSIS_DPHYCTRL,
val = (val & ~MIPI_CSIS_DPHYCTRL_HSSETTLE_MASK) MIPI_CSIS_DPHYCTRL_HSSETTLE(state->hs_settle));
| MIPI_CSIS_DPHYCTRL_HSSETTLE(state->hs_settle);
mipi_csis_write(state, MIPI_CSIS_DPHYCTRL, val);
val = (0 << MIPI_CSIS_ISPSYNC_HSYNC_LINTV_OFFSET) | val = (0 << MIPI_CSIS_ISPSYNC_HSYNC_LINTV_OFFSET) |
(0 << MIPI_CSIS_ISPSYNC_VSYNC_SINTV_OFFSET) | (0 << MIPI_CSIS_ISPSYNC_VSYNC_SINTV_OFFSET) |
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment