Commit d73f5d14 authored by Lv Ruyi's avatar Lv Ruyi Committed by Arnaldo Carvalho de Melo

perf stat: Fix error check return value of hashmap__new(), must use IS_ERR()

hashmap__new() returns ERR_PTR(-ENOMEM) when it fails, so we should use
IS_ERR() to check it in error handling path.
Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarLv Ruyi <lv.ruyi@zte.com.cn>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20220413093302.2538128-1-lv.ruyi@zte.com.cnSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent f034fc50
// SPDX-License-Identifier: GPL-2.0 // SPDX-License-Identifier: GPL-2.0
#include <errno.h> #include <errno.h>
#include <linux/err.h>
#include <inttypes.h> #include <inttypes.h>
#include <math.h> #include <math.h>
#include <string.h> #include <string.h>
...@@ -311,7 +312,7 @@ static int check_per_pkg(struct evsel *counter, struct perf_counts_values *vals, ...@@ -311,7 +312,7 @@ static int check_per_pkg(struct evsel *counter, struct perf_counts_values *vals,
if (!mask) { if (!mask) {
mask = hashmap__new(pkg_id_hash, pkg_id_equal, NULL); mask = hashmap__new(pkg_id_hash, pkg_id_equal, NULL);
if (!mask) if (IS_ERR(mask))
return -ENOMEM; return -ENOMEM;
counter->per_pkg_mask = mask; counter->per_pkg_mask = mask;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment