Commit d78678da authored by Ravishankar karkala Mallikarjunayya's avatar Ravishankar karkala Mallikarjunayya Committed by Greg Kroah-Hartman

Staging: comedi: fix printk issue in cb_pcidas64.c

This is a patch to the cb_pcidas64.c file that fixes up a
printk warning found by the checkpatch.pl tool.

Converted printks to dev_<levels> and Removed unnecessary
printk statements.
Signed-off-by: default avatarRavishankar Karkala Mallikarjunayya <ravishankar.km@greenturtles.in>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 94cc0b4a
...@@ -1739,8 +1739,6 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it) ...@@ -1739,8 +1739,6 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
uint32_t local_range, local_decode; uint32_t local_range, local_decode;
int retval; int retval;
printk("comedi%d: cb_pcidas64\n", dev->minor);
/* /*
* Allocate the private structure area. * Allocate the private structure area.
*/ */
...@@ -1781,12 +1779,11 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it) ...@@ -1781,12 +1779,11 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
return -EIO; return -EIO;
} }
printk("Found %s on bus %i, slot %i\n", board(dev)->name, dev_dbg(dev->hw_dev, "Found %s on bus %i, slot %i\n", board(dev)->name,
pcidev->bus->number, PCI_SLOT(pcidev->devfn)); pcidev->bus->number, PCI_SLOT(pcidev->devfn));
if (comedi_pci_enable(pcidev, driver_cb_pcidas.driver_name)) { if (comedi_pci_enable(pcidev, driver_cb_pcidas.driver_name)) {
printk(KERN_WARNING dev_warn(dev->hw_dev, "failed to enable PCI device and request regions\n");
" failed to enable PCI device and request regions\n");
return -EIO; return -EIO;
} }
pci_set_master(pcidev); pci_set_master(pcidev);
...@@ -1814,7 +1811,7 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it) ...@@ -1814,7 +1811,7 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
if (!priv(dev)->plx9080_iobase || !priv(dev)->main_iobase if (!priv(dev)->plx9080_iobase || !priv(dev)->main_iobase
|| !priv(dev)->dio_counter_iobase) { || !priv(dev)->dio_counter_iobase) {
printk(" failed to remap io memory\n"); dev_warn(dev->hw_dev, "failed to remap io memory\n");
return -ENOMEM; return -ENOMEM;
} }
...@@ -1850,17 +1847,19 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it) ...@@ -1850,17 +1847,19 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
priv(dev)->hw_revision = priv(dev)->hw_revision =
hw_revision(dev, readw(priv(dev)->main_iobase + HW_STATUS_REG)); hw_revision(dev, readw(priv(dev)->main_iobase + HW_STATUS_REG));
printk(" stc hardware revision %i\n", priv(dev)->hw_revision); dev_dbg(dev->hw_dev, "stc hardware revision %i\n",
priv(dev)->hw_revision);
init_plx9080(dev); init_plx9080(dev);
init_stc_registers(dev); init_stc_registers(dev);
/* get irq */ /* get irq */
if (request_irq(pcidev->irq, handle_interrupt, IRQF_SHARED, if (request_irq(pcidev->irq, handle_interrupt, IRQF_SHARED,
"cb_pcidas64", dev)) { "cb_pcidas64", dev)) {
printk(" unable to allocate irq %u\n", pcidev->irq); dev_dbg(dev->hw_dev, "unable to allocate irq %u\n",
pcidev->irq);
return -EINVAL; return -EINVAL;
} }
dev->irq = pcidev->irq; dev->irq = pcidev->irq;
printk(" irq %u\n", dev->irq); dev_dbg(dev->hw_dev, "irq %u\n", dev->irq);
retval = setup_subdevices(dev); retval = setup_subdevices(dev);
if (retval < 0) if (retval < 0)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment