Commit d796f4b7 authored by David S. Miller's avatar David S. Miller Committed by David S. Miller

[IPV6]: ip6_evictor() has same problem as ip_evictor().

Signed-off-by: default avatarDavid S. Miller <davem@redhat.com>
parent 00356691
...@@ -195,14 +195,18 @@ static void ip6_frag_secret_rebuild(unsigned long dummy) ...@@ -195,14 +195,18 @@ static void ip6_frag_secret_rebuild(unsigned long dummy)
atomic_t ip6_frag_mem = ATOMIC_INIT(0); atomic_t ip6_frag_mem = ATOMIC_INIT(0);
/* Memory Tracking Functions. */ /* Memory Tracking Functions. */
static inline void frag_kfree_skb(struct sk_buff *skb) static inline void frag_kfree_skb(struct sk_buff *skb, int *work)
{ {
if (work)
*work -= skb->truesize;
atomic_sub(skb->truesize, &ip6_frag_mem); atomic_sub(skb->truesize, &ip6_frag_mem);
kfree_skb(skb); kfree_skb(skb);
} }
static inline void frag_free_queue(struct frag_queue *fq) static inline void frag_free_queue(struct frag_queue *fq, int *work)
{ {
if (work)
*work -= sizeof(struct frag_queue);
atomic_sub(sizeof(struct frag_queue), &ip6_frag_mem); atomic_sub(sizeof(struct frag_queue), &ip6_frag_mem);
kfree(fq); kfree(fq);
} }
...@@ -220,7 +224,7 @@ static inline struct frag_queue *frag_alloc_queue(void) ...@@ -220,7 +224,7 @@ static inline struct frag_queue *frag_alloc_queue(void)
/* Destruction primitives. */ /* Destruction primitives. */
/* Complete destruction of fq. */ /* Complete destruction of fq. */
static void ip6_frag_destroy(struct frag_queue *fq) static void ip6_frag_destroy(struct frag_queue *fq, int *work)
{ {
struct sk_buff *fp; struct sk_buff *fp;
...@@ -232,17 +236,17 @@ static void ip6_frag_destroy(struct frag_queue *fq) ...@@ -232,17 +236,17 @@ static void ip6_frag_destroy(struct frag_queue *fq)
while (fp) { while (fp) {
struct sk_buff *xp = fp->next; struct sk_buff *xp = fp->next;
frag_kfree_skb(fp); frag_kfree_skb(fp, work);
fp = xp; fp = xp;
} }
frag_free_queue(fq); frag_free_queue(fq, work);
} }
static __inline__ void fq_put(struct frag_queue *fq) static __inline__ void fq_put(struct frag_queue *fq, int *work)
{ {
if (atomic_dec_and_test(&fq->refcnt)) if (atomic_dec_and_test(&fq->refcnt))
ip6_frag_destroy(fq); ip6_frag_destroy(fq, work);
} }
/* Kill fq entry. It is not destroyed immediately, /* Kill fq entry. It is not destroyed immediately,
...@@ -264,10 +268,13 @@ static void ip6_evictor(void) ...@@ -264,10 +268,13 @@ static void ip6_evictor(void)
{ {
struct frag_queue *fq; struct frag_queue *fq;
struct list_head *tmp; struct list_head *tmp;
int work;
for(;;) { work = atomic_read(&ip6_frag_mem) - sysctl_ip6frag_low_thresh;
if (atomic_read(&ip6_frag_mem) <= sysctl_ip6frag_low_thresh) if (work <= 0)
return; return;
while(work > 0) {
read_lock(&ip6_frag_lock); read_lock(&ip6_frag_lock);
if (list_empty(&ip6_frag_lru_list)) { if (list_empty(&ip6_frag_lru_list)) {
read_unlock(&ip6_frag_lock); read_unlock(&ip6_frag_lock);
...@@ -283,7 +290,7 @@ static void ip6_evictor(void) ...@@ -283,7 +290,7 @@ static void ip6_evictor(void)
fq_kill(fq); fq_kill(fq);
spin_unlock(&fq->lock); spin_unlock(&fq->lock);
fq_put(fq); fq_put(fq, &work);
IP6_INC_STATS_BH(IPSTATS_MIB_REASMFAILS); IP6_INC_STATS_BH(IPSTATS_MIB_REASMFAILS);
} }
} }
...@@ -320,7 +327,7 @@ static void ip6_frag_expire(unsigned long data) ...@@ -320,7 +327,7 @@ static void ip6_frag_expire(unsigned long data)
} }
out: out:
spin_unlock(&fq->lock); spin_unlock(&fq->lock);
fq_put(fq); fq_put(fq, NULL);
} }
/* Creation primitives. */ /* Creation primitives. */
...@@ -340,7 +347,7 @@ static struct frag_queue *ip6_frag_intern(unsigned int hash, ...@@ -340,7 +347,7 @@ static struct frag_queue *ip6_frag_intern(unsigned int hash,
atomic_inc(&fq->refcnt); atomic_inc(&fq->refcnt);
write_unlock(&ip6_frag_lock); write_unlock(&ip6_frag_lock);
fq_in->last_in |= COMPLETE; fq_in->last_in |= COMPLETE;
fq_put(fq_in); fq_put(fq_in, NULL);
return fq; return fq;
} }
} }
...@@ -539,7 +546,7 @@ static void ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb, ...@@ -539,7 +546,7 @@ static void ip6_frag_queue(struct frag_queue *fq, struct sk_buff *skb,
fq->fragments = next; fq->fragments = next;
fq->meat -= free_it->len; fq->meat -= free_it->len;
frag_kfree_skb(free_it); frag_kfree_skb(free_it, NULL);
} }
} }
...@@ -734,7 +741,7 @@ static int ipv6_frag_rcv(struct sk_buff **skbp, unsigned int *nhoffp) ...@@ -734,7 +741,7 @@ static int ipv6_frag_rcv(struct sk_buff **skbp, unsigned int *nhoffp)
ret = ip6_frag_reasm(fq, skbp, nhoffp, dev); ret = ip6_frag_reasm(fq, skbp, nhoffp, dev);
spin_unlock(&fq->lock); spin_unlock(&fq->lock);
fq_put(fq); fq_put(fq, NULL);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment