Commit d7b76421 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Daniel Lezcano

clocksource/drivers/timer-tegra186: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20230313075430.2730803-5-u.kleine-koenig@pengutronix.de
parent 8efcbe92
...@@ -447,15 +447,13 @@ static int tegra186_timer_probe(struct platform_device *pdev) ...@@ -447,15 +447,13 @@ static int tegra186_timer_probe(struct platform_device *pdev)
return err; return err;
} }
static int tegra186_timer_remove(struct platform_device *pdev) static void tegra186_timer_remove(struct platform_device *pdev)
{ {
struct tegra186_timer *tegra = platform_get_drvdata(pdev); struct tegra186_timer *tegra = platform_get_drvdata(pdev);
clocksource_unregister(&tegra->usec); clocksource_unregister(&tegra->usec);
clocksource_unregister(&tegra->osc); clocksource_unregister(&tegra->osc);
clocksource_unregister(&tegra->tsc); clocksource_unregister(&tegra->tsc);
return 0;
} }
static int __maybe_unused tegra186_timer_suspend(struct device *dev) static int __maybe_unused tegra186_timer_suspend(struct device *dev)
...@@ -505,7 +503,7 @@ static struct platform_driver tegra186_wdt_driver = { ...@@ -505,7 +503,7 @@ static struct platform_driver tegra186_wdt_driver = {
.of_match_table = tegra186_timer_of_match, .of_match_table = tegra186_timer_of_match,
}, },
.probe = tegra186_timer_probe, .probe = tegra186_timer_probe,
.remove = tegra186_timer_remove, .remove_new = tegra186_timer_remove,
}; };
module_platform_driver(tegra186_wdt_driver); module_platform_driver(tegra186_wdt_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment