Commit d7c41e83 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: pcmmio: tidy up pcmmio_handle_dio_intr()

Refactor the code to remove some of the indent levels.

Remove 'mytrig', the shift and mask end up making it the same as 'triggered'
anyway.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 967e7e5a
...@@ -359,50 +359,51 @@ static void pcmmio_handle_dio_intr(struct comedi_device *dev, ...@@ -359,50 +359,51 @@ static void pcmmio_handle_dio_intr(struct comedi_device *dev,
unsigned int triggered) unsigned int triggered)
{ {
struct pcmmio_private *devpriv = dev->private; struct pcmmio_private *devpriv = dev->private;
unsigned int oldevents = s->async->events;
unsigned int len = s->async->cmd.chanlist_len;
unsigned int val = 0;
unsigned long flags; unsigned long flags;
unsigned oldevents; int i;
spin_lock_irqsave(&devpriv->spinlock, flags); spin_lock_irqsave(&devpriv->spinlock, flags);
oldevents = s->async->events; if (!devpriv->active)
goto done;
if (devpriv->active) { if (!(triggered & devpriv->enabled_mask))
unsigned mytrig = ((triggered >> 0) & ((1 << 24) - 1)) << 0; goto done;
if (mytrig & devpriv->enabled_mask) {
unsigned int val = 0;
unsigned int n, ch, len;
len = s->async->cmd.chanlist_len; for (i = 0; i < len; i++) {
for (n = 0; n < len; n++) { unsigned int chan = CR_CHAN(s->async->cmd.chanlist[i]);
ch = CR_CHAN(s->async->cmd.chanlist[n]);
if (mytrig & (1U << ch)) if (triggered & (1 << chan))
val |= (1U << n); val |= (1 << i);
} }
/* Write the scan to the buffer. */
if (comedi_buf_put(s->async, val) && /* Write the scan to the buffer. */
comedi_buf_put (s->async, val >> 16)) { if (comedi_buf_put(s->async, val) &&
s->async->events |= (COMEDI_CB_BLOCK | COMEDI_CB_EOS); comedi_buf_put (s->async, val >> 16)) {
} else { s->async->events |= (COMEDI_CB_BLOCK | COMEDI_CB_EOS);
/* Overflow! Stop acquisition!! */ } else {
/* Overflow! Stop acquisition!! */
/* TODO: STOP_ACQUISITION_CALL_HERE!! */
pcmmio_stop_intr(dev, s);
}
/* Check for end of acquisition. */
if (!devpriv->continuous) {
/* stop_src == TRIG_COUNT */
if (devpriv->stop_count > 0) {
devpriv->stop_count--;
if (devpriv->stop_count == 0) {
s->async->events |= COMEDI_CB_EOA;
/* TODO: STOP_ACQUISITION_CALL_HERE!! */ /* TODO: STOP_ACQUISITION_CALL_HERE!! */
pcmmio_stop_intr(dev, s); pcmmio_stop_intr(dev, s);
} }
/* Check for end of acquisition. */
if (!devpriv->continuous) {
/* stop_src == TRIG_COUNT */
if (devpriv->stop_count > 0) {
devpriv->stop_count--;
if (devpriv->stop_count == 0) {
s->async->events |= COMEDI_CB_EOA;
/* TODO: STOP_ACQUISITION_CALL_HERE!! */
pcmmio_stop_intr(dev, s);
}
}
}
} }
} }
done:
spin_unlock_irqrestore(&devpriv->spinlock, flags); spin_unlock_irqrestore(&devpriv->spinlock, flags);
if (oldevents != s->async->events) if (oldevents != s->async->events)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment