Commit d7d75124 authored by Shay Drory's avatar Shay Drory Committed by David S. Miller

devlink: Fix devlink parallel commands processing

Commit 870c7ad4 ("devlink: protect devlink->dev by the instance
lock") added devlink instance locking inside a loop that iterates over
all the registered devlink instances on the machine in the pre-doit
phase. This can lead to serialization of devlink commands over
different devlink instances.

For example: While the first devlink instance is executing firmware
flash, all commands to other devlink instances on the machine are
forced to wait until the first devlink finishes.

Therefore, in the pre-doit phase, take the devlink instance lock only
for the devlink instance the command is targeting. Devlink layer is
taking a reference on the devlink instance, ensuring the devlink->dev
pointer is valid. This reference taking was introduced by commit
a3806872 ("devlink: take device reference for devlink object").
Without this commit, it would not be safe to access devlink->dev
lockless.

Fixes: 870c7ad4 ("devlink: protect devlink->dev by the instance lock")
Signed-off-by: default avatarShay Drory <shayd@nvidia.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 343041b5
...@@ -193,12 +193,13 @@ devlink_get_from_attrs_lock(struct net *net, struct nlattr **attrs, ...@@ -193,12 +193,13 @@ devlink_get_from_attrs_lock(struct net *net, struct nlattr **attrs,
devname = nla_data(attrs[DEVLINK_ATTR_DEV_NAME]); devname = nla_data(attrs[DEVLINK_ATTR_DEV_NAME]);
devlinks_xa_for_each_registered_get(net, index, devlink) { devlinks_xa_for_each_registered_get(net, index, devlink) {
devl_dev_lock(devlink, dev_lock); if (strcmp(devlink->dev->bus->name, busname) == 0 &&
if (devl_is_registered(devlink) && strcmp(dev_name(devlink->dev), devname) == 0) {
strcmp(devlink->dev->bus->name, busname) == 0 && devl_dev_lock(devlink, dev_lock);
strcmp(dev_name(devlink->dev), devname) == 0) if (devl_is_registered(devlink))
return devlink; return devlink;
devl_dev_unlock(devlink, dev_lock); devl_dev_unlock(devlink, dev_lock);
}
devlink_put(devlink); devlink_put(devlink);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment