Commit d8bb26b9 authored by Kalle Valo's avatar Kalle Valo

ath10k: else is not generally useful after a break or return

Fixes checkpatch warnings:

WARNING: else is not generally useful after a break or return
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent ac04506c
...@@ -1180,8 +1180,8 @@ int ath10k_debug_register(struct ath10k *ar) ...@@ -1180,8 +1180,8 @@ int ath10k_debug_register(struct ath10k *ar)
if (IS_ERR_OR_NULL(ar->debug.debugfs_phy)) { if (IS_ERR_OR_NULL(ar->debug.debugfs_phy)) {
if (IS_ERR(ar->debug.debugfs_phy)) if (IS_ERR(ar->debug.debugfs_phy))
return PTR_ERR(ar->debug.debugfs_phy); return PTR_ERR(ar->debug.debugfs_phy);
else
return -ENOMEM; return -ENOMEM;
} }
INIT_DELAYED_WORK(&ar->debug.htt_stats_dwork, INIT_DELAYED_WORK(&ar->debug.htt_stats_dwork,
......
...@@ -450,11 +450,11 @@ static int ath10k_htt_rx_amsdu_pop(struct ath10k_htt *htt, ...@@ -450,11 +450,11 @@ static int ath10k_htt_rx_amsdu_pop(struct ath10k_htt *htt,
if (last_msdu) { if (last_msdu) {
msdu->next = NULL; msdu->next = NULL;
break; break;
} else {
next = ath10k_htt_rx_netbuf_pop(htt);
msdu->next = next;
msdu = next;
} }
next = ath10k_htt_rx_netbuf_pop(htt);
msdu->next = next;
msdu = next;
} }
*tail_msdu = msdu; *tail_msdu = msdu;
...@@ -631,8 +631,8 @@ static struct ieee80211_hdr *ath10k_htt_rx_skb_get_hdr(struct sk_buff *skb) ...@@ -631,8 +631,8 @@ static struct ieee80211_hdr *ath10k_htt_rx_skb_get_hdr(struct sk_buff *skb)
if (fmt == RX_MSDU_DECAP_RAW) if (fmt == RX_MSDU_DECAP_RAW)
return (void *)skb->data; return (void *)skb->data;
else
return (void *)skb->data - RX_HTT_HDR_STATUS_LEN; return (void *)skb->data - RX_HTT_HDR_STATUS_LEN;
} }
/* This function only applies for first msdu in an msdu chain */ /* This function only applies for first msdu in an msdu chain */
......
...@@ -698,8 +698,8 @@ static int ath10k_monitor_recalc(struct ath10k *ar) ...@@ -698,8 +698,8 @@ static int ath10k_monitor_recalc(struct ath10k *ar)
if (should_start) if (should_start)
return ath10k_monitor_start(ar); return ath10k_monitor_start(ar);
else
return ath10k_monitor_stop(ar); return ath10k_monitor_stop(ar);
} }
static int ath10k_recalc_rtscts_prot(struct ath10k_vif *arvif) static int ath10k_recalc_rtscts_prot(struct ath10k_vif *arvif)
...@@ -4065,8 +4065,8 @@ ath10k_bitrate_mask_nss(const struct cfg80211_bitrate_mask *mask, ...@@ -4065,8 +4065,8 @@ ath10k_bitrate_mask_nss(const struct cfg80211_bitrate_mask *mask,
continue; continue;
else if (mask->control[band].ht_mcs[i] == 0x00) else if (mask->control[band].ht_mcs[i] == 0x00)
break; break;
else
return false; return false;
} }
ht_nss = i; ht_nss = i;
...@@ -4077,8 +4077,8 @@ ath10k_bitrate_mask_nss(const struct cfg80211_bitrate_mask *mask, ...@@ -4077,8 +4077,8 @@ ath10k_bitrate_mask_nss(const struct cfg80211_bitrate_mask *mask,
continue; continue;
else if (mask->control[band].vht_mcs[i] == 0x0000) else if (mask->control[band].vht_mcs[i] == 0x0000)
break; break;
else
return false; return false;
} }
vht_nss = i; vht_nss = i;
......
...@@ -362,10 +362,11 @@ static inline const char *ath10k_pci_get_irq_method(struct ath10k *ar) ...@@ -362,10 +362,11 @@ static inline const char *ath10k_pci_get_irq_method(struct ath10k *ar)
if (ar_pci->num_msi_intrs > 1) if (ar_pci->num_msi_intrs > 1)
return "msi-x"; return "msi-x";
else if (ar_pci->num_msi_intrs == 1)
if (ar_pci->num_msi_intrs == 1)
return "msi"; return "msi";
else
return "legacy"; return "legacy";
} }
static int __ath10k_pci_rx_post_buf(struct ath10k_pci_pipe *pipe) static int __ath10k_pci_rx_post_buf(struct ath10k_pci_pipe *pipe)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment