Commit d8dfab0f authored by Anson Huang's avatar Anson Huang Committed by Shawn Guo

soc: imx: soc-imx8: Avoid unnecessary of_node_put() in error handling

of_node_put() is called after of_match_node() successfully called,
then in the following error handling, of_node_put() is called again
which is unnecessary, this patch adjusts the location of of_node_put()
to avoid such scenario.
Signed-off-by: default avatarAnson Huang <Anson.Huang@nxp.com>
Reviewed-by: default avatarLeonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 15f5276a
......@@ -115,8 +115,6 @@ static int __init imx8_soc_init(void)
if (!id)
goto free_soc;
of_node_put(root);
data = id->data;
if (data) {
soc_dev_attr->soc_id = data->name;
......@@ -132,6 +130,8 @@ static int __init imx8_soc_init(void)
if (IS_ERR(soc_dev))
goto free_rev;
of_node_put(root);
return 0;
free_rev:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment