Commit d8f5df1f authored by Mohammad Nassiri's avatar Mohammad Nassiri Committed by Jakub Kicinski

selftests/net: Argument value mismatch when calling verify_counters()

The end_server() function only operates in the server thread
and always takes an accept socket instead of a listen socket as
its input argument. To align with this, invert the boolean values
used when calling verify_counters() within the end_server() function.

As a result of this typo, the test didn't correctly check for
the non-symmetrical scenario, where i.e. peer-A uses a key <100:200>
to send data, but peer-B uses another key <105:205> to send its data.
So, in simple words, different keys for TX and RX.

Fixes: 3c3ead55 ("selftests/net: Add TCP-AO key-management test")
Signed-off-by: default avatarMohammad Nassiri <mnassiri@ciena.com>
Link: https://lore.kernel.org/all/934627c5-eebb-4626-be23-cfb134c01d1a@arista.com/
[amended 'Fixes' tag, added the issue description and carried-over to lkml]
Signed-off-by: default avatarDmitry Safonov <dima@arista.com>
Link: https://lore.kernel.org/r/20240130-tcp-ao-test-key-mgmt-v2-1-d190430a6c60@arista.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 585b40e2
...@@ -843,7 +843,7 @@ static void end_server(const char *tst_name, int sk, ...@@ -843,7 +843,7 @@ static void end_server(const char *tst_name, int sk,
synchronize_threads(); /* 4: verified => closed */ synchronize_threads(); /* 4: verified => closed */
close(sk); close(sk);
verify_counters(tst_name, true, false, begin, &end); verify_counters(tst_name, false, true, begin, &end);
synchronize_threads(); /* 5: counters */ synchronize_threads(); /* 5: counters */
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment