Commit d905ae2b authored by Alexander Potapenko's avatar Alexander Potapenko Committed by Andrew Morton

mm: apply __must_check to vmap_pages_range_noflush()

To prevent errors when vmap_pages_range_noflush() or
__vmap_pages_range_noflush() silently fail (see the link below for an
example), annotate them with __must_check so that the callers do not
unconditionally assume the mapping succeeded.

Link: https://lkml.kernel.org/r/20230413131223.4135168-4-glider@google.comSigned-off-by: default avatarAlexander Potapenko <glider@google.com>
Reported-by: default avatarDipanjan Das <mail.dipanjan.das@gmail.com>
  Link: https://lore.kernel.org/linux-mm/CANX2M5ZRrRA64k0hOif02TjmY9kbbO2aCBPyq79es34RXZ=cAw@mail.gmail.com/Reviewed-by: default avatarMarco Elver <elver@google.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Uladzislau Rezki (Sony) <urezki@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent bb1508c2
...@@ -885,7 +885,7 @@ size_t splice_folio_into_pipe(struct pipe_inode_info *pipe, ...@@ -885,7 +885,7 @@ size_t splice_folio_into_pipe(struct pipe_inode_info *pipe,
*/ */
#ifdef CONFIG_MMU #ifdef CONFIG_MMU
void __init vmalloc_init(void); void __init vmalloc_init(void);
int vmap_pages_range_noflush(unsigned long addr, unsigned long end, int __must_check vmap_pages_range_noflush(unsigned long addr, unsigned long end,
pgprot_t prot, struct page **pages, unsigned int page_shift); pgprot_t prot, struct page **pages, unsigned int page_shift);
#else #else
static inline void vmalloc_init(void) static inline void vmalloc_init(void)
...@@ -893,16 +893,16 @@ static inline void vmalloc_init(void) ...@@ -893,16 +893,16 @@ static inline void vmalloc_init(void)
} }
static inline static inline
int vmap_pages_range_noflush(unsigned long addr, unsigned long end, int __must_check vmap_pages_range_noflush(unsigned long addr, unsigned long end,
pgprot_t prot, struct page **pages, unsigned int page_shift) pgprot_t prot, struct page **pages, unsigned int page_shift)
{ {
return -EINVAL; return -EINVAL;
} }
#endif #endif
int __vmap_pages_range_noflush(unsigned long addr, unsigned long end, int __must_check __vmap_pages_range_noflush(unsigned long addr,
pgprot_t prot, struct page **pages, unsigned long end, pgprot_t prot,
unsigned int page_shift); struct page **pages, unsigned int page_shift);
void vunmap_range_noflush(unsigned long start, unsigned long end); void vunmap_range_noflush(unsigned long start, unsigned long end);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment