Commit d9b1865c authored by Frederic Weisbecker's avatar Frederic Weisbecker Committed by Thomas Gleixner

tick: Assume the tick can't be stopped in NOHZ_MODE_INACTIVE mode

The full-nohz update function checks if the nohz mode is active before
proceeding. It considers one exception though: if the tick is already
stopped even though the nohz mode is inactive, it still moves on in
order to update/restart the tick if needed.

However in order for the tick to be stopped, the nohz_mode has to be
either NOHZ_MODE_LOWRES or NOHZ_MODE_HIGHRES. Therefore it doesn't make
sense to test if the tick is stopped before verifying NOHZ_MODE_INACTIVE
mode.

Remove the needless related condition.
Signed-off-by: default avatarFrederic Weisbecker <frederic@kernel.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240225225508.11587-11-frederic@kernel.org
parent ef8969bb
...@@ -1086,7 +1086,7 @@ static void tick_nohz_full_update_tick(struct tick_sched *ts) ...@@ -1086,7 +1086,7 @@ static void tick_nohz_full_update_tick(struct tick_sched *ts)
if (!tick_nohz_full_cpu(smp_processor_id())) if (!tick_nohz_full_cpu(smp_processor_id()))
return; return;
if (!ts->tick_stopped && ts->nohz_mode == NOHZ_MODE_INACTIVE) if (ts->nohz_mode == NOHZ_MODE_INACTIVE)
return; return;
__tick_nohz_full_update_tick(ts, ktime_get()); __tick_nohz_full_update_tick(ts, ktime_get());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment