Commit d9f31aea authored by Yang Li's avatar Yang Li Committed by Jakub Kicinski

ethernet: renesas: Use div64_ul instead of do_div

do_div() does a 64-by-32 division. Here the divisor is an
unsigned long which on some platforms is 64 bit wide. So use
div64_ul instead of do_div to avoid a possible truncation.

Eliminate the following coccicheck warning:
./drivers/net/ethernet/renesas/ravb_main.c:2492:1-7: WARNING:
do_div() does a 64-by-32 division, please consider using div64_ul
instead.
Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/1637228883-100100-1-git-send-email-yang.lee@linux.alibaba.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8d22679d
...@@ -30,8 +30,7 @@ ...@@ -30,8 +30,7 @@
#include <linux/spinlock.h> #include <linux/spinlock.h>
#include <linux/sys_soc.h> #include <linux/sys_soc.h>
#include <linux/reset.h> #include <linux/reset.h>
#include <linux/math64.h>
#include <asm/div64.h>
#include "ravb.h" #include "ravb.h"
...@@ -2488,8 +2487,7 @@ static int ravb_set_gti(struct net_device *ndev) ...@@ -2488,8 +2487,7 @@ static int ravb_set_gti(struct net_device *ndev)
if (!rate) if (!rate)
return -EINVAL; return -EINVAL;
inc = 1000000000ULL << 20; inc = div64_ul(1000000000ULL << 20, rate);
do_div(inc, rate);
if (inc < GTI_TIV_MIN || inc > GTI_TIV_MAX) { if (inc < GTI_TIV_MIN || inc > GTI_TIV_MAX) {
dev_err(dev, "gti.tiv increment 0x%llx is outside the range 0x%x - 0x%x\n", dev_err(dev, "gti.tiv increment 0x%llx is outside the range 0x%x - 0x%x\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment