Commit da5ecb4d authored by Oleg Drokin's avatar Oleg Drokin Committed by Greg Kroah-Hartman

staging/lustre: Fix braces {} style

This fixes all checkpatch form of this from the Lustre tree:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: default avatarOleg Drokin <green@linuxhacker.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f479924
......@@ -178,8 +178,9 @@ static void fld_fix_new_list(struct fld_cache *cache)
if (n_range->lsr_end <= c_range->lsr_end) {
*n_range = *c_range;
fld_cache_entry_delete(cache, f_curr);
} else
} else {
n_range->lsr_start = c_range->lsr_end;
}
}
/* we could have overlap over next
......
......@@ -1001,8 +1001,9 @@ static inline int lu_dirent_calc_size(int namelen, __u16 attr)
size = (sizeof(struct lu_dirent) + namelen + align) & ~align;
size += sizeof(struct luda_type);
} else
} else {
size = sizeof(struct lu_dirent) + namelen;
}
return (size + 7) & ~7;
}
......
......@@ -490,8 +490,9 @@ static inline int obd_setup(struct obd_device *obd, struct lustre_cfg *cfg)
obd->obd_lu_dev = d;
d->ld_obd = obd;
rc = 0;
} else
} else {
rc = PTR_ERR(d);
}
}
lu_context_exit(&session_ctx);
lu_context_fini(&session_ctx);
......
......@@ -1496,8 +1496,9 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
cmd == LL_IOC_MDC_GETINFO)) {
rc = 0;
goto skip_lmm;
} else
} else {
goto out_req;
}
}
if (cmd == IOC_MDC_GETFILESTRIPE ||
......@@ -1710,15 +1711,16 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
return ll_flush_ctx(inode);
#ifdef CONFIG_FS_POSIX_ACL
case LL_IOC_RMTACL: {
if (sbi->ll_flags & LL_SBI_RMT_CLIENT && is_root_inode(inode)) {
struct ll_file_data *fd = LUSTRE_FPRIVATE(file);
if (sbi->ll_flags & LL_SBI_RMT_CLIENT && is_root_inode(inode)) {
struct ll_file_data *fd = LUSTRE_FPRIVATE(file);
rc = rct_add(&sbi->ll_rct, current_pid(), arg);
if (!rc)
fd->fd_flags |= LL_FILE_RMTACL;
return rc;
} else
return 0;
rc = rct_add(&sbi->ll_rct, current_pid(), arg);
if (!rc)
fd->fd_flags |= LL_FILE_RMTACL;
return rc;
} else {
return 0;
}
}
#endif
case LL_IOC_GETOBDCOUNT: {
......
......@@ -323,8 +323,9 @@ static struct ll_inode_info *ll_close_next_lli(struct ll_close_queue *lcq)
lli = list_entry(lcq->lcq_head.next, struct ll_inode_info,
lli_close_list);
list_del_init(&lli->lli_close_list);
} else if (atomic_read(&lcq->lcq_stop))
} else if (atomic_read(&lcq->lcq_stop)) {
lli = ERR_PTR(-EALREADY);
}
spin_unlock(&lcq->lcq_lock);
return lli;
......
......@@ -1596,8 +1596,9 @@ void ll_update_inode(struct inode *inode, struct lustre_md *md)
" to the "DFID", inode %lu/%u(%p)\n",
PFID(&lli->lli_fid), PFID(&body->fid1),
inode->i_ino, inode->i_generation, inode);
} else
} else {
lli->lli_fid = body->fid1;
}
}
LASSERT(fid_seq(&lli->lli_fid) != 0);
......@@ -2065,11 +2066,11 @@ int ll_obd_statfs(struct inode *inode, void __user *arg)
}
memcpy(&type, data->ioc_inlbuf1, sizeof(__u32));
if (type & LL_STATFS_LMV)
if (type & LL_STATFS_LMV) {
exp = sbi->ll_md_exp;
else if (type & LL_STATFS_LOV)
} else if (type & LL_STATFS_LOV) {
exp = sbi->ll_dt_exp;
else {
} else {
rc = -ENODEV;
goto out_statfs;
}
......
......@@ -274,8 +274,9 @@ static void loop_add_bio(struct lloop_device *lo, struct bio *bio)
if (lo->lo_biotail) {
lo->lo_biotail->bi_next = bio;
lo->lo_biotail = bio;
} else
} else {
lo->lo_bio = lo->lo_biotail = bio;
}
spin_unlock_irqrestore(&lo->lo_lock, flags);
atomic_inc(&lo->lo_pending);
......
......@@ -128,10 +128,12 @@ struct inode *ll_iget(struct super_block *sb, ino_t hash,
if (rc != 0) {
iget_failed(inode);
inode = NULL;
} else
} else {
unlock_new_inode(inode);
} else if (!(inode->i_state & (I_FREEING | I_CLEAR)))
}
} else if (!(inode->i_state & (I_FREEING | I_CLEAR))) {
ll_update_inode(inode, md);
}
CDEBUG(D_VFSTRACE, "got inode: %p for "DFID"\n",
inode, PFID(&md->body->fid1));
}
......
......@@ -132,8 +132,9 @@ struct ll_cl_context *ll_cl_init(struct file *file, struct page *vmpage)
lcc->lcc_page = page;
lu_ref_add(&page->cp_reference, "cl_io", io);
result = 0;
} else
} else {
result = PTR_ERR(page);
}
}
if (result) {
ll_cl_fini(lcc);
......@@ -488,8 +489,9 @@ static int ll_read_ahead_pages(const struct lu_env *env,
if (rc == 1) {
(*reserved_pages)--;
count++;
} else if (rc == -ENOLCK)
} else if (rc == -ENOLCK) {
break;
}
} else if (stride_ria) {
/* If it is not in the read-ahead window, and it is
* read-ahead mode, then check whether it should skip
......
......@@ -98,8 +98,9 @@ static void ll_invalidatepage(struct page *vmpage, unsigned int offset,
cl_page_delete(env, page);
cl_page_put(env, page);
}
} else
} else {
LASSERT(vmpage->private == 0);
}
cl_env_put(env, &refcheck);
}
}
......
......@@ -342,8 +342,9 @@ int cl_sb_init(struct super_block *sb)
sbi->ll_site = cl2lu_dev(cl)->ld_site;
}
cl_env_put(env, &refcheck);
} else
} else {
rc = PTR_ERR(env);
}
return rc;
}
......@@ -588,16 +589,19 @@ static int vvp_pgcache_show(struct seq_file *f, void *v)
if (page) {
vvp_pgcache_page_show(env, f, page);
cl_page_put(env, page);
} else
} else {
seq_puts(f, "missing\n");
}
lu_object_ref_del(&clob->co_lu, "dump", current);
cl_object_put(env, clob);
} else
} else {
seq_printf(f, "%llx missing\n", pos);
}
cl_env_put(env, &refcheck);
result = 0;
} else
} else {
result = PTR_ERR(env);
}
return result;
}
......
......@@ -1178,8 +1178,9 @@ static int vvp_io_fault_start(const struct lu_env *env,
if (result == -EDQUOT)
result = -ENOSPC;
goto out;
} else
} else {
cl_page_disown(env, io, page);
}
}
}
......
......@@ -181,8 +181,9 @@ int ll_setxattr_common(struct inode *inode, const char *name,
size = rc;
pv = (const char *)new_value;
} else
} else {
return -EOPNOTSUPP;
}
valid |= rce_ops2valid(rce->rce_ops);
}
......
......@@ -1122,8 +1122,9 @@ static int lmv_iocontrol(unsigned int cmd, struct obd_export *exp,
if (!rc)
rc = err;
}
} else
} else {
set = 1;
}
}
if (!set && !rc)
rc = -EIO;
......
......@@ -262,8 +262,9 @@ static int lov_req_init(const struct lu_env *env, struct cl_device *dev,
if (lr) {
cl_req_slice_add(req, &lr->lr_cl, dev, &lov_req_ops);
result = 0;
} else
} else {
result = -ENOMEM;
}
return result;
}
......@@ -332,14 +333,15 @@ static struct lov_device_emerg **lov_emerg_alloc(int nr)
cl_page_list_init(&em->emrg_page_list);
em->emrg_env = cl_env_alloc(&em->emrg_refcheck,
LCT_REMEMBER | LCT_NOREF);
if (!IS_ERR(em->emrg_env))
if (!IS_ERR(em->emrg_env)) {
em->emrg_env->le_ctx.lc_cookie = 0x2;
else {
} else {
result = PTR_ERR(em->emrg_env);
em->emrg_env = NULL;
}
} else
} else {
result = -ENOMEM;
}
}
if (result != 0) {
lov_emerg_free(emerg, nr);
......
......@@ -225,8 +225,9 @@ struct lov_io_sub *lov_sub_get(const struct lu_env *env,
if (!sub->sub_io_initialized) {
sub->sub_stripe = stripe;
rc = lov_io_sub_init(env, lio, sub);
} else
} else {
rc = 0;
}
if (rc == 0)
lov_sub_enter(sub);
else
......@@ -294,8 +295,9 @@ static int lov_io_subio_init(const struct lu_env *env, struct lov_io *lio,
lio->lis_single_subio_index = -1;
lio->lis_active_subios = 0;
result = 0;
} else
} else {
result = -ENOMEM;
}
return result;
}
......@@ -413,8 +415,9 @@ static int lov_io_iter_init(const struct lu_env *env,
lov_sub_put(sub);
CDEBUG(D_VFSTRACE, "shrink: %d [%llu, %llu)\n",
stripe, start, end);
} else
} else {
rc = PTR_ERR(sub);
}
if (!rc)
list_add_tail(&sub->sub_linkage, &lio->lis_active);
......
......@@ -283,8 +283,9 @@ static int lov_init_raid0(const struct lu_env *env,
}
if (result == 0)
cl_object_header(&lov->lo_cl)->coh_page_bufsize += psz;
} else
} else {
result = -ENOMEM;
}
out:
return result;
}
......@@ -935,8 +936,9 @@ struct lu_object *lov_object_alloc(const struct lu_env *env,
* for object with different layouts.
*/
obj->lo_ops = &lov_lu_obj_ops;
} else
} else {
obj = NULL;
}
return obj;
}
......
......@@ -457,9 +457,9 @@ int lov_getstripe(struct obd_export *exp, struct lov_stripe_md *lsm,
}
/* User wasn't expecting this many OST entries */
if (lum.lmm_stripe_count == 0)
if (lum.lmm_stripe_count == 0) {
lmm_size = lum_size;
else if (lum.lmm_stripe_count < lmmk->lmm_stripe_count) {
} else if (lum.lmm_stripe_count < lmmk->lmm_stripe_count) {
rc = -EOVERFLOW;
goto out_set;
}
......
......@@ -151,8 +151,9 @@ static int lovsub_req_init(const struct lu_env *env, struct cl_device *dev,
if (lsr) {
cl_req_slice_add(req, &lsr->lsrq_cl, dev, &lovsub_req_ops);
result = 0;
} else
} else {
result = -ENOMEM;
}
return result;
}
......@@ -182,10 +183,12 @@ static struct lu_device *lovsub_device_alloc(const struct lu_env *env,
d = lovsub2lu_dev(lsd);
d->ld_ops = &lovsub_lu_ops;
lsd->acid_cl.cd_ops = &lovsub_cl_ops;
} else
} else {
d = ERR_PTR(result);
} else
}
} else {
d = ERR_PTR(-ENOMEM);
}
return d;
}
......
......@@ -77,8 +77,9 @@ int lovsub_lock_init(const struct lu_env *env, struct cl_object *obj,
INIT_LIST_HEAD(&lsk->lss_parents);
cl_lock_slice_add(lock, &lsk->lss_cl, obj, &lovsub_lock_ops);
result = 0;
} else
} else {
result = -ENOMEM;
}
return result;
}
......
......@@ -67,8 +67,9 @@ int lovsub_object_init(const struct lu_env *env, struct lu_object *obj,
lu_object_add(obj, below);
cl_object_page_init(lu2cl(obj), sizeof(struct lovsub_page));
result = 0;
} else
} else {
result = -ENOMEM;
}
return result;
}
......@@ -154,8 +155,9 @@ struct lu_object *lovsub_object_alloc(const struct lu_env *env,
lu_object_add_top(&hdr->coh_lu, obj);
los->lso_cl.co_ops = &lovsub_ops;
obj->lo_ops = &lovsub_lu_obj_ops;
} else
} else {
obj = NULL;
}
return obj;
}
......
......@@ -504,9 +504,9 @@ int cl_io_lock_add(const struct lu_env *env, struct cl_io *io,
{
int result;
if (cl_lockset_merge(&io->ci_lockset, &link->cill_descr))
if (cl_lockset_merge(&io->ci_lockset, &link->cill_descr)) {
result = 1;
else {
} else {
list_add(&link->cill_linkage, &io->ci_lockset.cls_todo);
result = 0;
}
......@@ -536,8 +536,9 @@ int cl_io_lock_alloc_add(const struct lu_env *env, struct cl_io *io,
result = cl_io_lock_add(env, io, link);
if (result) /* lock match */
link->cill_fini(env, link);
} else
} else {
result = -ENOMEM;
}
return result;
}
......@@ -1202,14 +1203,16 @@ struct cl_req *cl_req_alloc(const struct lu_env *env, struct cl_page *page,
if (req->crq_o) {
req->crq_nrobjs = nr_objects;
result = cl_req_init(env, req, page);
} else
} else {
result = -ENOMEM;
}
if (result != 0) {
cl_req_completion(env, req, result);
req = ERR_PTR(result);
}
} else
} else {
req = ERR_PTR(-ENOMEM);
}
return req;
}
EXPORT_SYMBOL(cl_req_alloc);
......
......@@ -654,8 +654,9 @@ static struct lu_env *cl_env_new(__u32 ctx_tags, __u32 ses_tags, void *debug)
lu_context_enter(&cle->ce_ses);
env->le_ses = &cle->ce_ses;
cl_env_init0(cle, debug);
} else
} else {
lu_env_fini(env);
}
}
if (rc != 0) {
kmem_cache_free(cl_env_kmem, cle);
......@@ -664,8 +665,9 @@ static struct lu_env *cl_env_new(__u32 ctx_tags, __u32 ses_tags, void *debug)
CL_ENV_INC(create);
CL_ENV_INC(total);
}
} else
} else {
env = ERR_PTR(-ENOMEM);
}
return env;
}
......@@ -1095,8 +1097,9 @@ struct cl_device *cl_type_setup(const struct lu_env *env, struct lu_site *site,
CERROR("can't init device '%s', %d\n", typename, rc);
d = ERR_PTR(rc);
}
} else
} else {
CERROR("Cannot allocate device: '%s'\n", typename);
}
return lu2cl_dev(d);
}
EXPORT_SYMBOL(cl_type_setup);
......
......@@ -694,8 +694,9 @@ int lprocfs_rd_import(struct seq_file *m, void *data)
do_div(sum, ret.lc_count);
ret.lc_sum = sum;
} else
} else {
ret.lc_sum = 0;
}
seq_printf(m,
" rpcs:\n"
" inflight: %u\n"
......
......@@ -716,8 +716,9 @@ struct lu_object *lu_object_find_slice(const struct lu_env *env,
obj = lu_object_locate(top->lo_header, dev->ld_type);
if (!obj)
lu_object_put(env, top);
} else
} else {
obj = top;
}
return obj;
}
EXPORT_SYMBOL(lu_object_find_slice);
......
......@@ -163,8 +163,9 @@ int class_del_uuid(const char *uuid)
break;
}
}
} else
} else {
list_splice_init(&g_uuid_list, &deathrow);
}
spin_unlock(&g_uuid_lock);
if (uuid && list_empty(&deathrow)) {
......
......@@ -842,8 +842,9 @@ int osc_req_init(const struct lu_env *env, struct cl_device *dev,
if (or) {
cl_req_slice_add(req, &or->or_cl, dev, &osc_req_ops);
result = 0;
} else
} else {
result = -ENOMEM;
}
return result;
}
......
......@@ -624,8 +624,9 @@ static int osc_ldlm_glimpse_ast(struct ldlm_lock *dlmlock, void *data)
result = -ELDLM_NO_LOCK_DATA;
}
cl_env_nested_put(&nest, env);
} else
} else {
result = PTR_ERR(env);
}
req->rq_status = result;
return result;
}
......
......@@ -292,8 +292,9 @@ struct lu_object *osc_object_alloc(const struct lu_env *env,
lu_object_init(obj, NULL, dev);
osc->oo_cl.co_ops = &osc_ops;
obj->lo_ops = &osc_lu_obj_ops;
} else
} else {
obj = NULL;
}
return obj;
}
......
......@@ -421,8 +421,9 @@ static int osc_cache_too_much(struct client_obd *cli)
return lru_shrink_max;
else if (pages >= budget / 2)
return lru_shrink_min;
} else if (pages >= budget * 2)
} else if (pages >= budget * 2) {
return lru_shrink_min;
}
return 0;
}
......
......@@ -3065,8 +3065,9 @@ static int osc_import_event(struct obd_device *obd,
ldlm_namespace_cleanup(ns, LDLM_FL_LOCAL_ONLY);
cl_env_put(env, &refcheck);
} else
} else {
rc = PTR_ERR(env);
}
break;
}
case IMP_EVENT_ACTIVE: {
......
......@@ -595,9 +595,9 @@ static int __ptlrpc_request_bufs_pack(struct ptlrpc_request *request,
struct obd_import *imp = request->rq_import;
int rc;
if (unlikely(ctx))
if (unlikely(ctx)) {
request->rq_cli_ctx = sptlrpc_cli_ctx_get(ctx);
else {
} else {
rc = sptlrpc_req_get_ctx(request);
if (rc)
goto out_free;
......
......@@ -679,11 +679,11 @@ static ssize_t ptlrpc_lprocfs_nrs_seq_write(struct file *file,
/**
* The second token is either NULL, or an optional [reg|hp] string
*/
if (strcmp(cmd, "reg") == 0)
if (strcmp(cmd, "reg") == 0) {
queue = PTLRPC_NRS_QUEUE_REG;
else if (strcmp(cmd, "hp") == 0)
} else if (strcmp(cmd, "hp") == 0) {
queue = PTLRPC_NRS_QUEUE_HP;
else {
} else {
rc = -EINVAL;
goto out;
}
......@@ -693,8 +693,9 @@ static ssize_t ptlrpc_lprocfs_nrs_seq_write(struct file *file,
if (queue == PTLRPC_NRS_QUEUE_HP && !nrs_svc_has_hp(svc)) {
rc = -ENODEV;
goto out;
} else if (queue == PTLRPC_NRS_QUEUE_BOTH && !nrs_svc_has_hp(svc))
} else if (queue == PTLRPC_NRS_QUEUE_BOTH && !nrs_svc_has_hp(svc)) {
queue = PTLRPC_NRS_QUEUE_REG;
}
/**
* Serialize NRS core lprocfs operations with policy registration/
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment