Commit daa35bd9 authored by Stephen Warren's avatar Stephen Warren Committed by Felipe Balbi

usb: gadget: serial: fix oops when data rx'd after close

When the gadget serial device has no associated TTY, do not pass any
received data into the TTY layer for processing; simply drop it instead.
This prevents the TTY layer from calling back into the gadget serial
driver, which will then crash in e.g. gs_write_room() due to lack of
gadget serial device to TTY association (i.e. a NULL pointer dereference).
Signed-off-by: default avatarStephen Warren <swarren@nvidia.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent afd7fd81
...@@ -537,7 +537,7 @@ static void gs_rx_push(unsigned long _port) ...@@ -537,7 +537,7 @@ static void gs_rx_push(unsigned long _port)
} }
/* push data to (open) tty */ /* push data to (open) tty */
if (req->actual) { if (req->actual && tty) {
char *packet = req->buf; char *packet = req->buf;
unsigned size = req->actual; unsigned size = req->actual;
unsigned n; unsigned n;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment