Commit dbb3bee8 authored by Yao Liu's avatar Yao Liu Committed by Kleber Sacilotto de Souza

nfs: Fix NULL pointer dereference of dev_name

BugLink: https://bugs.launchpad.net/bugs/1822271

[ Upstream commit 80ff0017 ]

There is a NULL pointer dereference of dev_name in nfs_parse_devname()

The oops looks something like:

  BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
  ...
  RIP: 0010:nfs_fs_mount+0x3b6/0xc20 [nfs]
  ...
  Call Trace:
   ? ida_alloc_range+0x34b/0x3d0
   ? nfs_clone_super+0x80/0x80 [nfs]
   ? nfs_free_parsed_mount_data+0x60/0x60 [nfs]
   mount_fs+0x52/0x170
   ? __init_waitqueue_head+0x3b/0x50
   vfs_kern_mount+0x6b/0x170
   do_mount+0x216/0xdc0
   ksys_mount+0x83/0xd0
   __x64_sys_mount+0x25/0x30
   do_syscall_64+0x65/0x220
   entry_SYSCALL_64_after_hwframe+0x49/0xbe

Fix this by adding a NULL check on dev_name
Signed-off-by: default avatarYao Liu <yotta.liu@ucloud.cn>
Signed-off-by: default avatarAnna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarStefan Bader <stefan.bader@canonical.com>
Acked-by: default avatarJuerg Haefliger <juerg.haefliger@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 8741b2c4
...@@ -1877,6 +1877,11 @@ static int nfs_parse_devname(const char *dev_name, ...@@ -1877,6 +1877,11 @@ static int nfs_parse_devname(const char *dev_name,
size_t len; size_t len;
char *end; char *end;
if (unlikely(!dev_name || !*dev_name)) {
dfprintk(MOUNT, "NFS: device name not specified\n");
return -EINVAL;
}
/* Is the host name protected with square brakcets? */ /* Is the host name protected with square brakcets? */
if (*dev_name == '[') { if (*dev_name == '[') {
end = strchr(++dev_name, ']'); end = strchr(++dev_name, ']');
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment