Commit dbdb8522 authored by Neil Armstrong's avatar Neil Armstrong Committed by Greg Kroah-Hartman

staging: rts5139: fix bad symbol declaration

With sparse, the following error appears :
  CHECK   drivers/staging/rts5139/ms_mg.c
drivers/staging/rts5139/ms_mg.c:82:5: warning: symbol 'mg_set_tpc_para_sub' was not declared. Should it be static?

Rename function with correct prefix and move declaration to coherent internal header file.
Signed-off-by: default avatarNeil 'Superna' Armstrong <superna9999@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 10f9f4ae
...@@ -36,6 +36,7 @@ ...@@ -36,6 +36,7 @@
#include "rts51x_scsi.h" #include "rts51x_scsi.h"
#include "rts51x_card.h" #include "rts51x_card.h"
#include "ms.h" #include "ms.h"
#include "ms_mg.h"
static inline void ms_set_err_code(struct rts51x_chip *chip, u8 err_code) static inline void ms_set_err_code(struct rts51x_chip *chip, u8 err_code)
{ {
...@@ -1183,10 +1184,6 @@ static int ms_read_attribute_info(struct rts51x_chip *chip) ...@@ -1183,10 +1184,6 @@ static int ms_read_attribute_info(struct rts51x_chip *chip)
return STATUS_SUCCESS; return STATUS_SUCCESS;
} }
#ifdef SUPPORT_MAGIC_GATE
int mg_set_tpc_para_sub(struct rts51x_chip *chip, int type, u8 mg_entry_num);
#endif
static int reset_ms_pro(struct rts51x_chip *chip) static int reset_ms_pro(struct rts51x_chip *chip)
{ {
struct ms_info *ms_card = &(chip->ms_card); struct ms_info *ms_card = &(chip->ms_card);
...@@ -1232,7 +1229,7 @@ static int reset_ms_pro(struct rts51x_chip *chip) ...@@ -1232,7 +1229,7 @@ static int reset_ms_pro(struct rts51x_chip *chip)
#endif #endif
#ifdef SUPPORT_MAGIC_GATE #ifdef SUPPORT_MAGIC_GATE
retval = mg_set_tpc_para_sub(chip, 0, 0); retval = rts51x_mg_set_tpc_para_sub(chip, 0, 0);
if (retval != STATUS_SUCCESS) if (retval != STATUS_SUCCESS)
TRACE_RET(chip, retval); TRACE_RET(chip, retval);
#endif #endif
......
...@@ -79,7 +79,7 @@ static int mg_send_ex_cmd(struct rts51x_chip *chip, u8 cmd, u8 entry_num) ...@@ -79,7 +79,7 @@ static int mg_send_ex_cmd(struct rts51x_chip *chip, u8 cmd, u8 entry_num)
return STATUS_SUCCESS; return STATUS_SUCCESS;
} }
int mg_set_tpc_para_sub(struct rts51x_chip *chip, int type, u8 mg_entry_num) int rts51x_mg_set_tpc_para_sub(struct rts51x_chip *chip, int type, u8 mg_entry_num)
{ {
int retval; int retval;
u8 buf[6]; u8 buf[6];
......
...@@ -30,6 +30,7 @@ ...@@ -30,6 +30,7 @@
#include "rts51x_chip.h" #include "rts51x_chip.h"
#include "ms.h" #include "ms.h"
int rts51x_mg_set_tpc_para_sub(struct rts51x_chip *chip, int type, u8 mg_entry_num);
int rts51x_mg_set_leaf_id(struct scsi_cmnd *srb, struct rts51x_chip *chip); int rts51x_mg_set_leaf_id(struct scsi_cmnd *srb, struct rts51x_chip *chip);
int rts51x_mg_get_local_EKB(struct scsi_cmnd *srb, struct rts51x_chip *chip); int rts51x_mg_get_local_EKB(struct scsi_cmnd *srb, struct rts51x_chip *chip);
int rts51x_mg_chg(struct scsi_cmnd *srb, struct rts51x_chip *chip); int rts51x_mg_chg(struct scsi_cmnd *srb, struct rts51x_chip *chip);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment