Commit dc2c733e authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Daniel Thompson

kdb: Use for_each_console() helper

Replace open coded single-linked list iteration loop with for_each_console()
helper in use.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
parent a4f8a7fb
...@@ -553,7 +553,7 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap) ...@@ -553,7 +553,7 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap)
int this_cpu, old_cpu; int this_cpu, old_cpu;
char *cp, *cp2, *cphold = NULL, replaced_byte = ' '; char *cp, *cp2, *cphold = NULL, replaced_byte = ' ';
char *moreprompt = "more> "; char *moreprompt = "more> ";
struct console *c = console_drivers; struct console *c;
unsigned long uninitialized_var(flags); unsigned long uninitialized_var(flags);
/* Serialize kdb_printf if multiple cpus try to write at once. /* Serialize kdb_printf if multiple cpus try to write at once.
...@@ -698,10 +698,9 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap) ...@@ -698,10 +698,9 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap)
cp2++; cp2++;
} }
} }
while (c) { for_each_console(c) {
c->write(c, cp, retlen - (cp - kdb_buffer)); c->write(c, cp, retlen - (cp - kdb_buffer));
touch_nmi_watchdog(); touch_nmi_watchdog();
c = c->next;
} }
} }
if (logging) { if (logging) {
...@@ -752,7 +751,6 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap) ...@@ -752,7 +751,6 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap)
moreprompt = "more> "; moreprompt = "more> ";
kdb_input_flush(); kdb_input_flush();
c = console_drivers;
if (dbg_io_ops && !dbg_io_ops->is_console) { if (dbg_io_ops && !dbg_io_ops->is_console) {
len = strlen(moreprompt); len = strlen(moreprompt);
...@@ -762,10 +760,9 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap) ...@@ -762,10 +760,9 @@ int vkdb_printf(enum kdb_msgsrc src, const char *fmt, va_list ap)
cp++; cp++;
} }
} }
while (c) { for_each_console(c) {
c->write(c, moreprompt, strlen(moreprompt)); c->write(c, moreprompt, strlen(moreprompt));
touch_nmi_watchdog(); touch_nmi_watchdog();
c = c->next;
} }
if (logging) if (logging)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment