Commit dc644b54 authored by Daniel Borkmann's avatar Daniel Borkmann Committed by Jakub Kicinski

tcx: Fix splat in ingress_destroy upon tcx_entry_free

On qdisc destruction, the ingress_destroy() needs to update the correct
entry, that is, tcx_entry_update must NULL the dev->tcx_ingress pointer.
Therefore, fix the typo.

Fixes: e420bed0 ("bpf: Add fd-based tcx multi-prog infra with link support")
Reported-by: syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com
Reported-by: syzbot+b202b7208664142954fa@syzkaller.appspotmail.com
Reported-by: syzbot+14736e249bce46091c18@syzkaller.appspotmail.com
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Tested-by: syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com
Tested-by: syzbot+b202b7208664142954fa@syzkaller.appspotmail.com
Tested-by: syzbot+14736e249bce46091c18@syzkaller.appspotmail.com
Tested-by: default avatarPetr Machata <petrm@nvidia.com>
Link: https://lore.kernel.org/r/20230721233330.5678-1-daniel@iogearbox.netSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5322a27c
...@@ -123,7 +123,7 @@ static void ingress_destroy(struct Qdisc *sch) ...@@ -123,7 +123,7 @@ static void ingress_destroy(struct Qdisc *sch)
if (entry) { if (entry) {
tcx_miniq_set_active(entry, false); tcx_miniq_set_active(entry, false);
if (!tcx_entry_is_active(entry)) { if (!tcx_entry_is_active(entry)) {
tcx_entry_update(dev, NULL, false); tcx_entry_update(dev, NULL, true);
tcx_entry_free(entry); tcx_entry_free(entry);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment