Commit dccd8557 authored by Vasily Averin's avatar Vasily Averin Committed by Jan Kara

fanotify: fix incorrect fmode_t casts

Fixes sparce warnings:
fs/notify/fanotify/fanotify_user.c:267:63: sparse:
 warning: restricted fmode_t degrades to integer
fs/notify/fanotify/fanotify_user.c:1351:28: sparse:
 warning: restricted fmode_t degrades to integer

FMODE_NONTIFY have bitwise fmode_t type and requires __force attribute
for any casts.
Signed-off-by: default avatarVasily Averin <vvs@openvz.org>
Reviewed-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/9adfd6ac-1b89-791e-796b-49ada3293985@openvz.org
parent e730558a
...@@ -264,7 +264,7 @@ static int create_fd(struct fsnotify_group *group, struct path *path, ...@@ -264,7 +264,7 @@ static int create_fd(struct fsnotify_group *group, struct path *path,
* originally opened O_WRONLY. * originally opened O_WRONLY.
*/ */
new_file = dentry_open(path, new_file = dentry_open(path,
group->fanotify_data.f_flags | FMODE_NONOTIFY, group->fanotify_data.f_flags | __FMODE_NONOTIFY,
current_cred()); current_cred());
if (IS_ERR(new_file)) { if (IS_ERR(new_file)) {
/* /*
...@@ -1377,7 +1377,7 @@ SYSCALL_DEFINE2(fanotify_init, unsigned int, flags, unsigned int, event_f_flags) ...@@ -1377,7 +1377,7 @@ SYSCALL_DEFINE2(fanotify_init, unsigned int, flags, unsigned int, event_f_flags)
(!(fid_mode & FAN_REPORT_NAME) || !(fid_mode & FAN_REPORT_FID))) (!(fid_mode & FAN_REPORT_NAME) || !(fid_mode & FAN_REPORT_FID)))
return -EINVAL; return -EINVAL;
f_flags = O_RDWR | FMODE_NONOTIFY; f_flags = O_RDWR | __FMODE_NONOTIFY;
if (flags & FAN_CLOEXEC) if (flags & FAN_CLOEXEC)
f_flags |= O_CLOEXEC; f_flags |= O_CLOEXEC;
if (flags & FAN_NONBLOCK) if (flags & FAN_NONBLOCK)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment