Commit dda8577f authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] dell_rbu tidy

Whitespace standardisation.

Cc: Abhay Salunke <Abhay_Salunke@dell.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent e61c0e33
...@@ -85,8 +85,7 @@ static struct platform_device *rbu_device; ...@@ -85,8 +85,7 @@ static struct platform_device *rbu_device;
static int context; static int context;
static dma_addr_t dell_rbu_dmaaddr; static dma_addr_t dell_rbu_dmaaddr;
static void static void init_packet_head(void)
init_packet_head(void)
{ {
INIT_LIST_HEAD(&packet_data_head.list); INIT_LIST_HEAD(&packet_data_head.list);
rbu_data.packet_write_count = 0; rbu_data.packet_write_count = 0;
...@@ -95,8 +94,7 @@ init_packet_head(void) ...@@ -95,8 +94,7 @@ init_packet_head(void)
rbu_data.packetsize = 0; rbu_data.packetsize = 0;
} }
static int static int fill_last_packet(void *data, size_t length)
fill_last_packet(void *data, size_t length)
{ {
struct list_head *ptemp_list; struct list_head *ptemp_list;
struct packet_data *packet = NULL; struct packet_data *packet = NULL;
...@@ -138,8 +136,7 @@ fill_last_packet(void *data, size_t length) ...@@ -138,8 +136,7 @@ fill_last_packet(void *data, size_t length)
return 0; return 0;
} }
static int static int create_packet(size_t length)
create_packet(size_t length)
{ {
struct packet_data *newpacket; struct packet_data *newpacket;
int ordernum = 0; int ordernum = 0;
...@@ -198,8 +195,7 @@ create_packet(size_t length) ...@@ -198,8 +195,7 @@ create_packet(size_t length)
return 0; return 0;
} }
static int static int packetize_data(void *data, size_t length)
packetize_data(void *data, size_t length)
{ {
int rc = 0; int rc = 0;
...@@ -213,8 +209,7 @@ packetize_data(void *data, size_t length) ...@@ -213,8 +209,7 @@ packetize_data(void *data, size_t length)
return rc; return rc;
} }
static int static int do_packet_read(char *data, struct list_head *ptemp_list,
do_packet_read(char *data, struct list_head *ptemp_list,
int length, int bytes_read, int *list_read_count) int length, int bytes_read, int *list_read_count)
{ {
void *ptemp_buf; void *ptemp_buf;
...@@ -248,8 +243,7 @@ do_packet_read(char *data, struct list_head *ptemp_list, ...@@ -248,8 +243,7 @@ do_packet_read(char *data, struct list_head *ptemp_list,
return bytes_copied; return bytes_copied;
} }
static int static int packet_read_list(char *data, size_t *pread_length)
packet_read_list(char *data, size_t * pread_length)
{ {
struct list_head *ptemp_list; struct list_head *ptemp_list;
int temp_count = 0; int temp_count = 0;
...@@ -287,8 +281,7 @@ packet_read_list(char *data, size_t * pread_length) ...@@ -287,8 +281,7 @@ packet_read_list(char *data, size_t * pread_length)
return 0; return 0;
} }
static void static void packet_empty_list(void)
packet_empty_list(void)
{ {
struct list_head *ptemp_list; struct list_head *ptemp_list;
struct list_head *pnext_list; struct list_head *pnext_list;
...@@ -320,8 +313,7 @@ packet_empty_list(void) ...@@ -320,8 +313,7 @@ packet_empty_list(void)
* img_update_free: Frees the buffer allocated for storing BIOS image * img_update_free: Frees the buffer allocated for storing BIOS image
* Always called with lock held and returned with lock held * Always called with lock held and returned with lock held
*/ */
static void static void img_update_free(void)
img_update_free(void)
{ {
if (!rbu_data.image_update_buffer) if (!rbu_data.image_update_buffer)
return; return;
...@@ -358,8 +350,7 @@ img_update_free(void) ...@@ -358,8 +350,7 @@ img_update_free(void)
* already allocated size, then that memory is reused. This function is * already allocated size, then that memory is reused. This function is
* called with lock held and returns with lock held. * called with lock held and returns with lock held.
*/ */
static int static int img_update_realloc(unsigned long size)
img_update_realloc(unsigned long size)
{ {
unsigned char *image_update_buffer = NULL; unsigned char *image_update_buffer = NULL;
unsigned long rc; unsigned long rc;
...@@ -428,8 +419,7 @@ img_update_realloc(unsigned long size) ...@@ -428,8 +419,7 @@ img_update_realloc(unsigned long size)
return rc; return rc;
} }
static ssize_t static ssize_t read_packet_data(char *buffer, loff_t pos, size_t count)
read_packet_data(char *buffer, loff_t pos, size_t count)
{ {
int retval; int retval;
size_t bytes_left; size_t bytes_left;
...@@ -470,8 +460,7 @@ read_packet_data(char *buffer, loff_t pos, size_t count) ...@@ -470,8 +460,7 @@ read_packet_data(char *buffer, loff_t pos, size_t count)
return retval; return retval;
} }
static ssize_t static ssize_t read_rbu_mono_data(char *buffer, loff_t pos, size_t count)
read_rbu_mono_data(char *buffer, loff_t pos, size_t count)
{ {
unsigned char *ptemp = NULL; unsigned char *ptemp = NULL;
size_t bytes_left = 0; size_t bytes_left = 0;
...@@ -509,8 +498,8 @@ read_rbu_mono_data(char *buffer, loff_t pos, size_t count) ...@@ -509,8 +498,8 @@ read_rbu_mono_data(char *buffer, loff_t pos, size_t count)
return ret_count; return ret_count;
} }
static ssize_t static ssize_t read_rbu_data(struct kobject *kobj, char *buffer,
read_rbu_data(struct kobject *kobj, char *buffer, loff_t pos, size_t count) loff_t pos, size_t count)
{ {
ssize_t ret_count = 0; ssize_t ret_count = 0;
...@@ -527,8 +516,7 @@ read_rbu_data(struct kobject *kobj, char *buffer, loff_t pos, size_t count) ...@@ -527,8 +516,7 @@ read_rbu_data(struct kobject *kobj, char *buffer, loff_t pos, size_t count)
return ret_count; return ret_count;
} }
static void static void callbackfn_rbu(const struct firmware *fw, void *context)
callbackfn_rbu(const struct firmware *fw, void *context)
{ {
int rc = 0; int rc = 0;
...@@ -564,9 +552,8 @@ callbackfn_rbu(const struct firmware *fw, void *context) ...@@ -564,9 +552,8 @@ callbackfn_rbu(const struct firmware *fw, void *context)
rbu_data.entry_created = 1; rbu_data.entry_created = 1;
} }
static ssize_t static ssize_t read_rbu_image_type(struct kobject *kobj, char *buffer,
read_rbu_image_type(struct kobject *kobj, char *buffer, loff_t pos, loff_t pos, size_t count)
size_t count)
{ {
int size = 0; int size = 0;
if (!pos) if (!pos)
...@@ -574,9 +561,8 @@ read_rbu_image_type(struct kobject *kobj, char *buffer, loff_t pos, ...@@ -574,9 +561,8 @@ read_rbu_image_type(struct kobject *kobj, char *buffer, loff_t pos,
return size; return size;
} }
static ssize_t static ssize_t write_rbu_image_type(struct kobject *kobj, char *buffer,
write_rbu_image_type(struct kobject *kobj, char *buffer, loff_t pos, loff_t pos, size_t count)
size_t count)
{ {
int rc = count; int rc = count;
int req_firm_rc = 0; int req_firm_rc = 0;
...@@ -636,18 +622,25 @@ write_rbu_image_type(struct kobject *kobj, char *buffer, loff_t pos, ...@@ -636,18 +622,25 @@ write_rbu_image_type(struct kobject *kobj, char *buffer, loff_t pos,
} }
static struct bin_attribute rbu_data_attr = { static struct bin_attribute rbu_data_attr = {
.attr = {.name = "data",.owner = THIS_MODULE,.mode = 0444}, .attr = {
.name = "data",
.owner = THIS_MODULE,
.mode = 0444,
},
.read = read_rbu_data, .read = read_rbu_data,
}; };
static struct bin_attribute rbu_image_type_attr = { static struct bin_attribute rbu_image_type_attr = {
.attr = {.name = "image_type",.owner = THIS_MODULE,.mode = 0644}, .attr = {
.name = "image_type",
.owner = THIS_MODULE,
.mode = 0644,
},
.read = read_rbu_image_type, .read = read_rbu_image_type,
.write = write_rbu_image_type, .write = write_rbu_image_type,
}; };
static int __init static int __init dcdrbu_init(void)
dcdrbu_init(void)
{ {
int rc = 0; int rc = 0;
spin_lock_init(&rbu_data.lock); spin_lock_init(&rbu_data.lock);
...@@ -677,8 +670,7 @@ dcdrbu_init(void) ...@@ -677,8 +670,7 @@ dcdrbu_init(void)
} }
static __exit void static __exit void dcdrbu_exit(void)
dcdrbu_exit(void)
{ {
spin_lock(&rbu_data.lock); spin_lock(&rbu_data.lock);
packet_empty_list(); packet_empty_list();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment