Commit ddf75a86 authored by Jianglei Nie's avatar Jianglei Nie Committed by Miguel Ojeda

auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()

hd44780_probe() allocates a memory chunk for hd with kzalloc() and
makes "lcd->drvdata->hd44780" point to it. When we call hd44780_remove(),
we should release all relevant memory and resource. But "lcd->drvdata
->hd44780" is not released, which will lead to a memory leak.

We should release the "lcd->drvdata->hd44780" in hd44780_remove() to fix
the memory leak bug.

Fixes: 718e05ed ("auxdisplay: Introduce hd44780_common.[ch]")
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarJianglei Nie <niejianglei2021@163.com>
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 830b3c68
...@@ -322,8 +322,10 @@ static int hd44780_probe(struct platform_device *pdev) ...@@ -322,8 +322,10 @@ static int hd44780_probe(struct platform_device *pdev)
static int hd44780_remove(struct platform_device *pdev) static int hd44780_remove(struct platform_device *pdev)
{ {
struct charlcd *lcd = platform_get_drvdata(pdev); struct charlcd *lcd = platform_get_drvdata(pdev);
struct hd44780_common *hdc = lcd->drvdata;
charlcd_unregister(lcd); charlcd_unregister(lcd);
kfree(hdc->hd44780);
kfree(lcd->drvdata); kfree(lcd->drvdata);
kfree(lcd); kfree(lcd);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment