Commit de04f865 authored by Steven Rostedt's avatar Steven Rostedt Committed by Jiri Olsa

tools lib traceevent: Fix memory leak in pretty_print()

Commit 12e55569 "tools lib traceevent: Use helper trace-seq in print
functions like kernel does" added a extra trace_seq helper to process
string arguments like the kernel does it. But the difference between the
kernel and the userspace library is that the kernel's trace_seq structure
has a static allocated buffer. The userspace one has a dynamically
allocated one. It requires a trace_seq_destroy(), otherwise it produces
a nasty memory leak.

Cc: stable@vger.kernel.org # 3.14+
Signed-off-by: default avatarSteven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20140422192330.6bb09bf8@gandalf.local.homeSigned-off-by: default avatarJiri Olsa <jolsa@redhat.com>
parent 45087935
...@@ -4344,6 +4344,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event ...@@ -4344,6 +4344,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
format, len_arg, arg); format, len_arg, arg);
trace_seq_terminate(&p); trace_seq_terminate(&p);
trace_seq_puts(s, p.buffer); trace_seq_puts(s, p.buffer);
trace_seq_destroy(&p);
arg = arg->next; arg = arg->next;
break; break;
default: default:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment