Commit de669ae8 authored by Bob Pearson's avatar Bob Pearson Committed by Jason Gunthorpe

RDMA/rxe: Removed unused name from rxe_task struct

The name field in struct rxe_task is never used. This patch removes it.

Link: https://lore.kernel.org/r/20221021200118.2163-4-rpearsonhpe@gmail.comSigned-off-by: default avatarIan Ziemba <ian.ziemba@hpe.com>
Signed-off-by: default avatarBob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 98a54f17
...@@ -238,10 +238,8 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp, ...@@ -238,10 +238,8 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp,
skb_queue_head_init(&qp->req_pkts); skb_queue_head_init(&qp->req_pkts);
rxe_init_task(&qp->req.task, qp, rxe_init_task(&qp->req.task, qp, rxe_requester);
rxe_requester, "req"); rxe_init_task(&qp->comp.task, qp, rxe_completer);
rxe_init_task(&qp->comp.task, qp,
rxe_completer, "comp");
qp->qp_timeout_jiffies = 0; /* Can't be set for UD/UC in modify_qp */ qp->qp_timeout_jiffies = 0; /* Can't be set for UD/UC in modify_qp */
if (init->qp_type == IB_QPT_RC) { if (init->qp_type == IB_QPT_RC) {
...@@ -288,8 +286,7 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp, ...@@ -288,8 +286,7 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp,
skb_queue_head_init(&qp->resp_pkts); skb_queue_head_init(&qp->resp_pkts);
rxe_init_task(&qp->resp.task, qp, rxe_init_task(&qp->resp.task, qp, rxe_responder);
rxe_responder, "resp");
qp->resp.opcode = OPCODE_NONE; qp->resp.opcode = OPCODE_NONE;
qp->resp.msn = 0; qp->resp.msn = 0;
......
...@@ -90,12 +90,10 @@ void rxe_do_task(struct tasklet_struct *t) ...@@ -90,12 +90,10 @@ void rxe_do_task(struct tasklet_struct *t)
task->ret = ret; task->ret = ret;
} }
int rxe_init_task(struct rxe_task *task, int rxe_init_task(struct rxe_task *task, void *arg, int (*func)(void *))
void *arg, int (*func)(void *), char *name)
{ {
task->arg = arg; task->arg = arg;
task->func = func; task->func = func;
snprintf(task->name, sizeof(task->name), "%s", name);
task->destroyed = false; task->destroyed = false;
tasklet_setup(&task->tasklet, rxe_do_task); tasklet_setup(&task->tasklet, rxe_do_task);
......
...@@ -25,7 +25,6 @@ struct rxe_task { ...@@ -25,7 +25,6 @@ struct rxe_task {
void *arg; void *arg;
int (*func)(void *arg); int (*func)(void *arg);
int ret; int ret;
char name[16];
bool destroyed; bool destroyed;
}; };
...@@ -34,8 +33,7 @@ struct rxe_task { ...@@ -34,8 +33,7 @@ struct rxe_task {
* arg => parameter to pass to fcn * arg => parameter to pass to fcn
* func => function to call until it returns != 0 * func => function to call until it returns != 0
*/ */
int rxe_init_task(struct rxe_task *task, int rxe_init_task(struct rxe_task *task, void *arg, int (*func)(void *));
void *arg, int (*func)(void *), char *name);
/* cleanup task */ /* cleanup task */
void rxe_cleanup_task(struct rxe_task *task); void rxe_cleanup_task(struct rxe_task *task);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment