Commit df11f6c5 authored by Andy Shevchenko's avatar Andy Shevchenko

platform/x86: thinkpad_acpi: Revert "Use strndup_user() in dispatch_proc_write()"

This reverts commit 35d13c7a.

This broke procfs interface due to neglecting the fact that
the strings are not coming NULL terminated.

Revert the change till we will have a better clean up.

Fixes: 35d13c7a ("platform/x86: thinkpad_acpi: Use strndup_user() in dispatch_proc_write()")
Reported-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 13bceda6
...@@ -885,11 +885,19 @@ static ssize_t dispatch_proc_write(struct file *file, ...@@ -885,11 +885,19 @@ static ssize_t dispatch_proc_write(struct file *file,
if (!ibm || !ibm->write) if (!ibm || !ibm->write)
return -EINVAL; return -EINVAL;
if (count > PAGE_SIZE - 1)
return -EINVAL;
kernbuf = kmalloc(count + 1, GFP_KERNEL);
if (!kernbuf)
return -ENOMEM;
kernbuf = strndup_user(userbuf, PAGE_SIZE); if (copy_from_user(kernbuf, userbuf, count)) {
if (IS_ERR(kernbuf)) kfree(kernbuf);
return PTR_ERR(kernbuf); return -EFAULT;
}
kernbuf[count] = 0;
ret = ibm->write(kernbuf); ret = ibm->write(kernbuf);
if (ret == 0) if (ret == 0)
ret = count; ret = count;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment