Commit dfd10332 authored by Russ Weight's avatar Russ Weight Committed by Xu Yilun

fpga: m10bmc-sec: Fix kconfig dependencies

The secure update driver depends on the firmware-upload functionality of
the firmware-loader. The firmware-loader is carried in the firmware-class
driver which is enabled with the tristate CONFIG_FW_LOADER option. The
firmware-upload functionality is included in the firmware-class driver if
the bool FW_UPLOAD config is set.

The current dependency statement, "depends on FW_UPLOAD", is not adequate
because it does not implicitly turn on FW_LOADER. Instead of adding a
dependency, follow the convention used by drivers that require the
FW_LOADER_USER_HELPER functionality of the firmware-loader by using
select for both FW_LOADER and FW_UPLOAD.

Fixes: bdf86d0e ("fpga: m10bmc-sec: create max10 bmc secure update")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarRuss Weight <russell.h.weight@intel.com>
Acked-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Acked-by: default avatarXu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20221115001127.289890-1-russell.h.weight@intel.comSigned-off-by: default avatarXu Yilun <yilun.xu@intel.com>
parent 9abf2313
...@@ -246,7 +246,9 @@ config FPGA_MGR_VERSAL_FPGA ...@@ -246,7 +246,9 @@ config FPGA_MGR_VERSAL_FPGA
config FPGA_M10_BMC_SEC_UPDATE config FPGA_M10_BMC_SEC_UPDATE
tristate "Intel MAX10 BMC Secure Update driver" tristate "Intel MAX10 BMC Secure Update driver"
depends on MFD_INTEL_M10_BMC && FW_UPLOAD depends on MFD_INTEL_M10_BMC
select FW_LOADER
select FW_UPLOAD
help help
Secure update support for the Intel MAX10 board management Secure update support for the Intel MAX10 board management
controller. controller.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment