Commit e11b7085 authored by Kirill A. Shutemov's avatar Kirill A. Shutemov Committed by Greg Kroah-Hartman

pagemap: do not leak physical addresses to non-privileged userspace

commit ab676b7d upstream.

As pointed by recent post[1] on exploiting DRAM physical imperfection,
/proc/PID/pagemap exposes sensitive information which can be used to do
attacks.

This disallows anybody without CAP_SYS_ADMIN to read the pagemap.

[1] http://googleprojectzero.blogspot.com/2015/03/exploiting-dram-rowhammer-bug-to-gain.html

[ Eventually we might want to do anything more finegrained, but for now
  this is the simple model.   - Linus ]
Signed-off-by: default avatarKirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: default avatarKonstantin Khlebnikov <khlebnikov@openvz.org>
Acked-by: default avatarAndy Lutomirski <luto@amacapital.net>
Cc: Pavel Emelyanov <xemul@parallels.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Mark Seaborn <mseaborn@chromium.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarmancha security <mancha1@zoho.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 391f1c61
...@@ -1110,9 +1110,19 @@ static ssize_t pagemap_read(struct file *file, char __user *buf, ...@@ -1110,9 +1110,19 @@ static ssize_t pagemap_read(struct file *file, char __user *buf,
return ret; return ret;
} }
static int pagemap_open(struct inode *inode, struct file *file)
{
/* do not disclose physical addresses to unprivileged
userspace (closes a rowhammer attack vector) */
if (!capable(CAP_SYS_ADMIN))
return -EPERM;
return 0;
}
const struct file_operations proc_pagemap_operations = { const struct file_operations proc_pagemap_operations = {
.llseek = mem_lseek, /* borrow this */ .llseek = mem_lseek, /* borrow this */
.read = pagemap_read, .read = pagemap_read,
.open = pagemap_open,
}; };
#endif /* CONFIG_PROC_PAGE_MONITOR */ #endif /* CONFIG_PROC_PAGE_MONITOR */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment