Commit e1d6ca04 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

firmware: stratix10-svc: Fix an NULL vs IS_ERR() bug in probe

The svc_create_memory_pool() function returns error pointers.  It never
returns NULL.  Fix the check.

Fixes: 7ca5ce89 ("firmware: add Intel Stratix10 service layer driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/5f9a8cb4-5a4f-460b-9cdc-2fae6c5b7922@kili.mountainSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 12124d16
...@@ -1133,8 +1133,8 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev) ...@@ -1133,8 +1133,8 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev)
return ret; return ret;
genpool = svc_create_memory_pool(pdev, sh_memory); genpool = svc_create_memory_pool(pdev, sh_memory);
if (!genpool) if (IS_ERR(genpool))
return -ENOMEM; return PTR_ERR(genpool);
/* allocate service controller and supporting channel */ /* allocate service controller and supporting channel */
controller = devm_kzalloc(dev, sizeof(*controller), GFP_KERNEL); controller = devm_kzalloc(dev, sizeof(*controller), GFP_KERNEL);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment