Commit e1f0fbda authored by Colin Ian King's avatar Colin Ian King Committed by Chris Wilson

drm/i915: fix uninitialized pointer reads on pointers to and from

Currently pointers to and from are not initialized and may contain
garbage values. This will cause uninitialized pointer reads in the
call to intel_frontbuffer_track and later checks to see if to and from
are null.  Fix this by ensuring to and from are initialized to NULL.

Addresses-Coverity: ("Uninitialised pointer read)"
Fixes: da42104f ("drm/i915: Hold reference to intel_frontbuffer as we track activity")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20191219190916.24693-1-colin.king@canonical.com
parent 28117632
...@@ -279,7 +279,7 @@ static void intel_overlay_flip_prepare(struct intel_overlay *overlay, ...@@ -279,7 +279,7 @@ static void intel_overlay_flip_prepare(struct intel_overlay *overlay,
struct i915_vma *vma) struct i915_vma *vma)
{ {
enum pipe pipe = overlay->crtc->pipe; enum pipe pipe = overlay->crtc->pipe;
struct intel_frontbuffer *from, *to; struct intel_frontbuffer *from = NULL, *to = NULL;
WARN_ON(overlay->old_vma); WARN_ON(overlay->old_vma);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment