Commit e21cf434 authored by Vincent Guittot's avatar Vincent Guittot Committed by Borislav Petkov

sched/cfs: change initial value of runnable_avg

Some performance regression on reaim benchmark have been raised with
  commit 070f5e86 ("sched/fair: Take into account runnable_avg to classify group")

The problem comes from the init value of runnable_avg which is initialized
with max value. This can be a problem if the newly forked task is finally
a short task because the group of CPUs is wrongly set to overloaded and
tasks are pulled less agressively.

Set initial value of runnable_avg equals to util_avg to reflect that there
is no waiting time so far.

Fixes: 070f5e86 ("sched/fair: Take into account runnable_avg to classify group")
Reported-by: default avatarkernel test robot <rong.a.chen@intel.com>
Signed-off-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20200624154422.29166-1-vincent.guittot@linaro.org
parent 8c4890d1
......@@ -806,7 +806,7 @@ void post_init_entity_util_avg(struct task_struct *p)
}
}
sa->runnable_avg = cpu_scale;
sa->runnable_avg = sa->util_avg;
if (p->sched_class != &fair_sched_class) {
/*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment