Commit e2984494 authored by Alan Cox's avatar Alan Cox Committed by Greg Kroah-Hartman

USB: serial: Note mos7480 and option don't lock modem status

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 9b0f2582
...@@ -1722,6 +1722,7 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file, ...@@ -1722,6 +1722,7 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file,
if (mos7840_port == NULL) if (mos7840_port == NULL)
return -ENODEV; return -ENODEV;
/* FIXME: What locks the port registers ? */
mcr = mos7840_port->shadowMCR; mcr = mos7840_port->shadowMCR;
if (clear & TIOCM_RTS) if (clear & TIOCM_RTS)
mcr &= ~MCR_RTS; mcr &= ~MCR_RTS;
......
...@@ -458,6 +458,7 @@ static int option_tiocmset(struct usb_serial_port *port, struct file *file, ...@@ -458,6 +458,7 @@ static int option_tiocmset(struct usb_serial_port *port, struct file *file,
portdata = usb_get_serial_port_data(port); portdata = usb_get_serial_port_data(port);
/* FIXME: what locks portdata fields ? */
if (set & TIOCM_RTS) if (set & TIOCM_RTS)
portdata->rts_state = 1; portdata->rts_state = 1;
if (set & TIOCM_DTR) if (set & TIOCM_DTR)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment