Commit e39d5246 authored by Xin Long's avatar Xin Long Committed by David S. Miller

route: update fnhe_expires for redirect when the fnhe exists

Now when creating fnhe for redirect, it sets fnhe_expires for this
new route cache. But when updating the exist one, it doesn't do it.
It will cause this fnhe never to be expired.

Paolo already noticed it before, in Jianlin's test case, it became
even worse:

When ip route flush cache, the old fnhe is not to be removed, but
only clean it's members. When redirect comes again, this fnhe will
be found and updated, but never be expired due to fnhe_expires not
being set.

So fix it by simply updating fnhe_expires even it's for redirect.

Fixes: aee06da6 ("ipv4: use seqlock for nh_exceptions")
Reported-by: default avatarJianlin Shi <jishi@redhat.com>
Acked-by: default avatarHannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ecca8f88
...@@ -678,10 +678,9 @@ static void update_or_create_fnhe(struct fib_nh *nh, __be32 daddr, __be32 gw, ...@@ -678,10 +678,9 @@ static void update_or_create_fnhe(struct fib_nh *nh, __be32 daddr, __be32 gw,
if (fnhe) { if (fnhe) {
if (gw) if (gw)
fnhe->fnhe_gw = gw; fnhe->fnhe_gw = gw;
if (pmtu) { if (pmtu)
fnhe->fnhe_pmtu = pmtu; fnhe->fnhe_pmtu = pmtu;
fnhe->fnhe_expires = max(1UL, expires); fnhe->fnhe_expires = max(1UL, expires);
}
/* Update all cached dsts too */ /* Update all cached dsts too */
rt = rcu_dereference(fnhe->fnhe_rth_input); rt = rcu_dereference(fnhe->fnhe_rth_input);
if (rt) if (rt)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment