Commit e3f0c638 authored by Tony Lindgren's avatar Tony Lindgren Committed by Greg Kroah-Hartman

serial: 8250: omap: Fix unpaired pm_runtime_put_sync() in omap8250_remove()

On remove, we get an error for "Runtime PM usage count underflow!". I guess
this driver is mostly built-in, and this issue has gone unnoticed for a
while. Somehow I did not catch this issue with my earlier fix done with
commit 4e0f5cc6 ("serial: 8250_omap: Fix probe and remove for PM
runtime").

Fixes: 4e0f5cc6 ("serial: 8250_omap: Fix probe and remove for PM runtime")
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
Depends-on: dd8088d5 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
Link: https://lore.kernel.org/r/20221028105813.54290-1-tony@atomide.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e828e566
......@@ -1460,6 +1460,11 @@ static int omap8250_probe(struct platform_device *pdev)
static int omap8250_remove(struct platform_device *pdev)
{
struct omap8250_priv *priv = platform_get_drvdata(pdev);
int err;
err = pm_runtime_resume_and_get(&pdev->dev);
if (err)
return err;
pm_runtime_dont_use_autosuspend(&pdev->dev);
pm_runtime_put_sync(&pdev->dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment