Commit e4655196 authored by Ricardo Ribalda's avatar Ricardo Ribalda Committed by Julia Lawall

coccinelle: misc: minmax: Suppress reports for err returns

Most of the people prefer:

return ret < 0 ? ret: 0;

than:

return min(ret, 0);

Let's tweak the cocci file to ignore those lines completely.
Signed-off-by: default avatarRicardo Ribalda <ribalda@chromium.org>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@inria.fr>
parent 96fca68c
...@@ -50,11 +50,26 @@ func(...) ...@@ -50,11 +50,26 @@ func(...)
...> ...>
} }
// Ignore errcode returns.
@errcode@
position p;
identifier func;
expression x;
binary operator cmp = {<, <=};
@@
func(...)
{
<...
return ((x) cmp@p 0 ? (x) : 0);
...>
}
@rmin depends on !patch@ @rmin depends on !patch@
identifier func; identifier func;
expression x, y; expression x, y;
binary operator cmp = {<, <=}; binary operator cmp = {<, <=};
position p; position p != errcode.p;
@@ @@
func(...) func(...)
...@@ -116,21 +131,6 @@ func(...) ...@@ -116,21 +131,6 @@ func(...)
...> ...>
} }
// Don't generate patches for errcode returns.
@errcode depends on patch@
position p;
identifier func;
expression x;
binary operator cmp = {<, <=};
@@
func(...)
{
<...
return ((x) cmp@p 0 ? (x) : 0);
...>
}
@pmin depends on patch@ @pmin depends on patch@
identifier func; identifier func;
expression x, y; expression x, y;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment