Commit e502babe authored by Anton Vorontsov's avatar Anton Vorontsov Committed by Greg Kroah-Hartman

sysrq: Fix possible race with exiting task

sysrq should grab the tasklist lock, otherwise calling force_sig() is
not safe, as it might race with exiting task, which ->sighand might be
set to NULL already.
Signed-off-by: default avatarAnton Vorontsov <anton.vorontsov@linaro.org>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6f56d0f4
...@@ -322,11 +322,13 @@ static void send_sig_all(int sig) ...@@ -322,11 +322,13 @@ static void send_sig_all(int sig)
{ {
struct task_struct *p; struct task_struct *p;
read_lock(&tasklist_lock);
for_each_process(p) { for_each_process(p) {
if (p->mm && !is_global_init(p)) if (p->mm && !is_global_init(p))
/* Not swapper, init nor kernel thread */ /* Not swapper, init nor kernel thread */
force_sig(sig, p); force_sig(sig, p);
} }
read_unlock(&tasklist_lock);
} }
static void sysrq_handle_term(int key) static void sysrq_handle_term(int key)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment