Commit e56d97b1 authored by Dan Carpenter's avatar Dan Carpenter Committed by Kleber Sacilotto de Souza

net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe()

BugLink: https://bugs.launchpad.net/bugs/1864773

[ Upstream commit 25a58495 ]

The "priv->phy_interface" variable is an enum and in this context GCC
will treat it as unsigned so the error handling will never be
triggered.

Fixes: 80105bef ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarKhalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: default avatarKleber Sacilotto de Souza <kleber.souza@canonical.com>
parent 81d29da2
...@@ -1794,7 +1794,7 @@ static int bcm_sysport_probe(struct platform_device *pdev) ...@@ -1794,7 +1794,7 @@ static int bcm_sysport_probe(struct platform_device *pdev)
priv->phy_interface = of_get_phy_mode(dn); priv->phy_interface = of_get_phy_mode(dn);
/* Default to GMII interface mode */ /* Default to GMII interface mode */
if (priv->phy_interface < 0) if ((int)priv->phy_interface < 0)
priv->phy_interface = PHY_INTERFACE_MODE_GMII; priv->phy_interface = PHY_INTERFACE_MODE_GMII;
/* In the case of a fixed PHY, the DT node associated /* In the case of a fixed PHY, the DT node associated
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment