Commit e592dc32 authored by Minghao Chi's avatar Minghao Chi Committed by Patrik Jakobsson

drm/gma500: remove redundant ret variable

Return value directly instead of taking this in another redundant
variable.
Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarMinghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: default avatarCGEL ZTE <cgel.zte@gmail.com>
Signed-off-by: default avatarPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220112082524.667552-1-chi.minghao@zte.com.cn
parent d1f5a6d9
...@@ -82,7 +82,6 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading) ...@@ -82,7 +82,6 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading)
{ {
struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data; struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
int mode = MODE_I2C_START; int mode = MODE_I2C_START;
int ret;
if (reading) if (reading)
mode |= MODE_I2C_READ; mode |= MODE_I2C_READ;
...@@ -90,8 +89,7 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading) ...@@ -90,8 +89,7 @@ i2c_algo_dp_aux_address(struct i2c_adapter *adapter, u16 address, bool reading)
mode |= MODE_I2C_WRITE; mode |= MODE_I2C_WRITE;
algo_data->address = address; algo_data->address = address;
algo_data->running = true; algo_data->running = true;
ret = i2c_algo_dp_aux_transaction(adapter, mode, 0, NULL); return i2c_algo_dp_aux_transaction(adapter, mode, 0, NULL);
return ret;
} }
/* /*
...@@ -122,13 +120,11 @@ static int ...@@ -122,13 +120,11 @@ static int
i2c_algo_dp_aux_put_byte(struct i2c_adapter *adapter, u8 byte) i2c_algo_dp_aux_put_byte(struct i2c_adapter *adapter, u8 byte)
{ {
struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data; struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
int ret;
if (!algo_data->running) if (!algo_data->running)
return -EIO; return -EIO;
ret = i2c_algo_dp_aux_transaction(adapter, MODE_I2C_WRITE, byte, NULL); return i2c_algo_dp_aux_transaction(adapter, MODE_I2C_WRITE, byte, NULL);
return ret;
} }
/* /*
...@@ -139,13 +135,11 @@ static int ...@@ -139,13 +135,11 @@ static int
i2c_algo_dp_aux_get_byte(struct i2c_adapter *adapter, u8 *byte_ret) i2c_algo_dp_aux_get_byte(struct i2c_adapter *adapter, u8 *byte_ret)
{ {
struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data; struct i2c_algo_dp_aux_data *algo_data = adapter->algo_data;
int ret;
if (!algo_data->running) if (!algo_data->running)
return -EIO; return -EIO;
ret = i2c_algo_dp_aux_transaction(adapter, MODE_I2C_READ, 0, byte_ret); return i2c_algo_dp_aux_transaction(adapter, MODE_I2C_READ, 0, byte_ret);
return ret;
} }
static int static int
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment