Commit e59d8bb5 authored by Pan Bian's avatar Pan Bian Committed by Takashi Iwai

ALSA: echoaudio: Fix improper return value in function load_asic

When the second call to load_asic_generic() fails in function
load_asic(), "false" is returned. The real value of "false" is 0, which
indicates success in the context. As a result, the execution status and
the return value may be inconsistent. This patch fixes the bug.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188761Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c6790c8e
...@@ -135,7 +135,7 @@ static int load_asic(struct echoaudio *chip) ...@@ -135,7 +135,7 @@ static int load_asic(struct echoaudio *chip)
err = load_asic_generic(chip, DSP_FNC_LOAD_LAYLA24_EXTERNAL_ASIC, err = load_asic_generic(chip, DSP_FNC_LOAD_LAYLA24_EXTERNAL_ASIC,
FW_LAYLA24_2S_ASIC); FW_LAYLA24_2S_ASIC);
if (err < 0) if (err < 0)
return false; return err;
/* Now give the external ASIC a little time to set up */ /* Now give the external ASIC a little time to set up */
mdelay(10); mdelay(10);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment