Commit e5b310f9 authored by Michael Strauss's avatar Michael Strauss Committed by Alex Deucher

drm/amd/display: Initialize lt_settings on instantiation

[WHY]
lt_settings' pointers remain uninitialized but nonzero if display fails
to light up with no DPCD/EDID info populated, leading to a hang on access
Reviewed-by: default avatarNicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
Acked-by: default avatarMikita Lipski <mikita.lipski@amd.com>
Signed-off-by: default avatarMichael Strauss <michael.strauss@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 0e62b094
...@@ -1561,7 +1561,7 @@ bool dc_link_dp_perform_link_training_skip_aux( ...@@ -1561,7 +1561,7 @@ bool dc_link_dp_perform_link_training_skip_aux(
struct dc_link *link, struct dc_link *link,
const struct dc_link_settings *link_setting) const struct dc_link_settings *link_setting)
{ {
struct link_training_settings lt_settings; struct link_training_settings lt_settings = {0};
dp_decide_training_settings( dp_decide_training_settings(
link, link,
...@@ -1707,7 +1707,7 @@ enum link_training_result dc_link_dp_perform_link_training( ...@@ -1707,7 +1707,7 @@ enum link_training_result dc_link_dp_perform_link_training(
bool skip_video_pattern) bool skip_video_pattern)
{ {
enum link_training_result status = LINK_TRAINING_SUCCESS; enum link_training_result status = LINK_TRAINING_SUCCESS;
struct link_training_settings lt_settings; struct link_training_settings lt_settings = {0};
enum dp_link_encoding encoding = enum dp_link_encoding encoding =
dp_get_link_encoding_format(link_settings); dp_get_link_encoding_format(link_settings);
...@@ -1923,7 +1923,7 @@ enum link_training_result dc_link_dp_sync_lt_attempt( ...@@ -1923,7 +1923,7 @@ enum link_training_result dc_link_dp_sync_lt_attempt(
struct dc_link_settings *link_settings, struct dc_link_settings *link_settings,
struct dc_link_training_overrides *lt_overrides) struct dc_link_training_overrides *lt_overrides)
{ {
struct link_training_settings lt_settings; struct link_training_settings lt_settings = {0};
enum link_training_result lt_status = LINK_TRAINING_SUCCESS; enum link_training_result lt_status = LINK_TRAINING_SUCCESS;
enum dp_panel_mode panel_mode = DP_PANEL_MODE_DEFAULT; enum dp_panel_mode panel_mode = DP_PANEL_MODE_DEFAULT;
enum clock_source_id dp_cs_id = CLOCK_SOURCE_ID_EXTERNAL; enum clock_source_id dp_cs_id = CLOCK_SOURCE_ID_EXTERNAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment